Skip to content

Restore Critic verify-by-temporary-test workflow - #957

Merged
TheGreatAxios merged 1 commit into
mainfrom
cl-7655-critic-temp-test-workflow
Sep 13, 2026
Merged

TheGreatAxios merged 1 commit into
mainfrom
cl-7655-critic-temp-test-workflow

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Collaborator

Summary

  • Restores the verify-by-temporary-test workflow in the Critic prompt: form hypotheses, write temp tests under tmp/critique-tests, run them, report only verified issues, recommend keepers for permanent inclusion
  • Keeps the existing API-contract check, this-diff hygiene, and never-fix rules intact; the shared scaffold still owns the report envelope

Verification

  • bun run typecheck, bun run build, and bun run test pass
  • bun run check passes: 7133 pass, 0 fail
  • Critic contract tests cover the temp-test workflow and the no-envelope rule

Fixes CL-7655

@linear-code

linear-code Bot commented Sep 12, 2026

Copy link
Copy Markdown

CL-7655

@TheGreatAxios

Copy link
Copy Markdown
Collaborator Author

Audit: Approve. Verify-by-temporary-test workflow restored with the repo-native tmp/critique-tests/ path, hypothesis-first discipline, report-only-verified-issues, and keepers routed to testsmith/builder without committing from here. Honest pin attribution noted and appreciated: the header states pin 6e16b6c does not resolve locally, so wording was verified against critique.md at local HEAD c0efce7 rather than copied 1:1. The fidelity claim is correctly scoped to what was actually verified.

@TheGreatAxios
TheGreatAxios merged commit 910427f into main Sep 13, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant