Restore Emil critique layer from the CMO original at full fidelity - #954
TheGreatAxios wants to merge 2 commits into
Conversation
The design-eng overhaul had narrowed the prompt to a laws digest; port back every dropped section from the CMO source. Deviations are enumerated in the package header.
|
Audit: the CMO-original restore content (capabilities, Thinking & Reasoning laws, Boy Scout Rule, cross-reference checklist, temp-test workflow, guidelines, negative constraints) is faithful and worth landing. One blocking issue: Envelope ownership: #968 establishes that the scaffold owns the worker report envelope (Summary/Findings/Blockers/Paths) and lane packages must not re-specify it — and #968 wins that conflict. The restored |
|
Audit (fleet builder): envelope ownership — #968 WINS, yield here. The scaffold owns the worker report envelope (Summary / Findings / Blockers / Paths), so in-package prompt formats must not re-specify headings. This PR's |
The shared scaffold owns Summary / Findings / Blockers / Paths, so the restored CMO report content is carried as Findings sub-bullets instead of re-specified headings. Deviation comment 5 updated to match.
|
Superseded by #999 (fresh rebase under CL-7800's name, release 0.3.26). |
Restores Emil's CMO prompt layer at full fidelity: ports back every section the design-eng overhaul narrowed away (capabilities, Thinking and Reasoning laws, Boy Scout Rule, cross-reference checklist, temp-test workflow, full report format, guidelines, negative constraints). Tests assert the restored contract; prompt-size budgets raised deliberately.
Source pin: abklabs/agents
plugins/cmo/agents/emil.md@e1d626cc6b7c6c2911a94daccd7793cc03633e26(2026-04-21; only commit ever touching that file).Deviations from the source (deliberate, exhaustive; also in the package header):
skills: brand-identityhas no Corbits equivalent; substance inlined.tmp/critique-tests/kept verbatim.Fleet fields unchanged (deliberate): maySpawn false, REVIEW_TOOLS, modelRole review, tier leaf; source
model: sonnetis an agents-repo pin, not carried over.Terminology note: the ticket says 'copy/messaging layer'; the pinned source contains no copy/messaging content (it is the design-eng critique agent housed in the CMO plugin), so this restores the prompt copy at full fidelity and adds no marketing lane. Flagging in case the ticket meant something else.
Verification:
bun test src/agent/directors/emil/20 pass;bun run typecheckexit 0; full suitebun test ./src ./tests ./evals ./scripts --randomize --seed 4242427139 pass / 0 fail;bun run checkexit 0.Fixes CL-7800