Stop sending contextWindow as the request max_tokens - #933
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contextWindowno longer changes the request output budget; every provider branch keeps the shared source defaultcontextWindowstill drives compaction and the status-bar meter viacontextWindowFor, and the provider-branch behavior is now documented in IMPLEMENTATION.mdcontextWindow(only tests reference it), so no existing deployment changes behaviorVerification
bun test src/config/inference-sources.test.ts src/provider/context-window.test.ts src/provider/openai-compatible-adapter.test.ts src/pricing-metadata.test.ts src/cost/cost-summary.test.ts tests/unit/context-window.test.tspasses (73 pass, 0 fail)bun test src/config.test.tspasses (94 pass, 0 fail)bun run checkpasses (lint, typecheck, build, 6982 pass, 0 fail)max_tokens16384, not 400000, whilecontextWindowForstill returns 400000Fixes CL-7784