Grant an open overlay its minimum even below the prompt floor - #927
Merged
TheGreatAxios merged 1 commit intoSep 12, 2026
Merged
TheGreatAxios merged 1 commit into
TheGreatAxios merged 1 commit into
Conversation
An unanswerable approval deadlocks the session; a cramped prompt does not. Best-effort geometry re-checks the overlay minimum and may take rows from below the prompt floor so the border still closes and at least one choice remains painted.
TheGreatAxios
commented
Sep 12, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Critic · Approve
The overlay takes prompt rows as needed while preserving a closed, bounded frame and a visible approval choice at 6, 7, and 9 terminal rows.
No findings.
Notes
bun test src/tui/overlay-min-geometry.test.ts src/tui/decision-truncation.test.ts src/tui/palette-paint.test.tspasses 30 tests, including rendered-frame assertions for all three target heights.bun run typecheckpasses.
TheGreatAxios
deleted the
cl-6986-resolvegeometrys-best-effort-fallback-can-size-an-overlay
branch
September 12, 2026 04:06
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
minOverlaywhen any terminal rows exist.Verification
bun run typecheck,bun run build, andbun run testpassbun run checkpasses (6972 tests)Fixes CL-6986