Skip to content

Salvage stub plan findings as an incomplete report - #919

Merged
TheGreatAxios merged 2 commits into
mainfrom
cl-7756-salvage-plancounsel-stub-findings-as-incomplete-not-a
Sep 11, 2026
Merged

TheGreatAxios merged 2 commits into
mainfrom
cl-7756-salvage-plancounsel-stub-findings-as-incomplete-not-a

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Collaborator

Summary

  • Counsel and intent=plan workers require Findings substance (files/paths, acceptance criteria, non-goals, risks, ordered steps). Four headings with stub Findings salvage as incomplete-report, not an attachable plan.
  • hasReportEnvelope stays heading-presence only. Implement and review envelope completeness is unchanged. Gaasbot is not armed (modelRole === "plan" is not the key).
  • Wait JSON still carries stop_reason: incomplete-report so the parent does not treat a stub plan as a clean complete.

Verification

  • bun run typecheck, bun run build, and bun run test pass
  • bun run check passes (6895 tests, 0 fail)
  • Targeted: bun test ./src/subagent/index.test.ts ./src/subagent/nudge-director.test.ts ./src/prompts.test.ts ./src/agent/directors/skywalker/package.test.ts ./src/subagent/agent-fleet.test.ts (250 pass, 0 fail)

Fixes CL-7756

@linear-code

linear-code Bot commented Sep 11, 2026

Copy link
Copy Markdown

CL-7756

@TheGreatAxios

Copy link
Copy Markdown
Collaborator Author

Independent critic — request changes

Stub salvage wiring matches CL-7756 (cycle 1 nudge, cycle 2 incomplete-report-stop, implement/review unchanged, gaasbot unarmed). Do not merge until the Findings classifier is heading-only.

Blocking: classifyPlanSectionLine matches /\bsteps\b/ and /\brisks?\b/ anywhere on a Findings line. A real five-section plan whose Acceptance criteria says “The worker completes the salvage steps.” is classified as a steps heading, AC is truncated empty, and later ### Ordered steps is ignored → hasPlanFindings false → salvage. Tests only use a keyword-safe PASS_PLAN_ENVELOPE.

Fix: section labels must match heading or numbered-item starts, not body prose. Permanent tests: five-section plan with “steps” (and separately “risks”) in an earlier body still completes; counsel numbered labels with following-line substance complete.

@TheGreatAxios

Copy link
Copy Markdown
Collaborator Author

Independent critic (re-review of d24f80c)

Prior blocking classifier bug is fixed. Mid-sentence “steps”/“risks” no longer open plan sections. Stub salvage, implement/review, gaasbot-unarmed, and heading-only envelope still hold.

Merge.

A four-heading envelope with placeholder Findings would otherwise
complete and look like an attachable plan.
Body prose that mentioned steps or risks was treated as a section
start, so a five-section plan could lose its real Ordered steps
heading and salvage as incomplete.
@TheGreatAxios
TheGreatAxios force-pushed the cl-7756-salvage-plancounsel-stub-findings-as-incomplete-not-a branch from d24f80c to 68ea6e0 Compare September 11, 2026 22:28
@TheGreatAxios
TheGreatAxios merged commit 8947ee7 into main Sep 11, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant