Salvage stub plan findings as an incomplete report - #919
TheGreatAxios merged 2 commits into
Conversation
Independent critic — request changesStub salvage wiring matches CL-7756 (cycle 1 nudge, cycle 2 Blocking: Fix: section labels must match heading or numbered-item starts, not body prose. Permanent tests: five-section plan with “steps” (and separately “risks”) in an earlier body still completes; counsel numbered labels with following-line substance complete. |
Independent critic (re-review of d24f80c)Prior blocking classifier bug is fixed. Mid-sentence “steps”/“risks” no longer open plan sections. Stub salvage, implement/review, gaasbot-unarmed, and heading-only envelope still hold. Merge. |
A four-heading envelope with placeholder Findings would otherwise complete and look like an attachable plan.
Body prose that mentioned steps or risks was treated as a section start, so a five-section plan could lose its real Ordered steps heading and salvage as incomplete.
d24f80c to
68ea6e0
Compare
Summary
intent=planworkers require Findings substance (files/paths, acceptance criteria, non-goals, risks, ordered steps). Four headings with stub Findings salvage asincomplete-report, not an attachable plan.hasReportEnvelopestays heading-presence only. Implement and review envelope completeness is unchanged. Gaasbot is not armed (modelRole === "plan"is not the key).stop_reason: incomplete-reportso the parent does not treat a stub plan as a clean complete.Verification
bun run typecheck,bun run build, andbun run testpassbun run checkpasses (6895 tests, 0 fail)bun test ./src/subagent/index.test.ts ./src/subagent/nudge-director.test.ts ./src/prompts.test.ts ./src/agent/directors/skywalker/package.test.ts ./src/subagent/agent-fleet.test.ts(250 pass, 0 fail)Fixes CL-7756