Skip to content

Refuse list_agents after a parked director question is surfaced - #918

Merged
TheGreatAxios merged 1 commit into
mainfrom
cl-7757-answer-parked-ask_director-before-polling-list_agents
Sep 11, 2026
Merged

TheGreatAxios merged 1 commit into
mainfrom
cl-7757-answer-parked-ask_director-before-polling-list_agents

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Collaborator

Summary

  • After a parked ask_director is surfaced (TUI idle-send wake, nested wait_agents with a question payload, or a successful list_agents), further list_agents calls fail closed until send_input answers or the ask is dropped.
  • First list may surface the question once; a new question_id is listable once. wait_agents stays mounted. Occupancy latch is unchanged.

Verification

  • bun run typecheck, bun run build, and bun run test pass
  • Targeted fleet tests pass under --randomize --seed 424242 (170 pass)
  • bun run check (lint, typecheck, build, guarded suite: 6893 pass)

Fixes CL-7757

@linear-code

linear-code Bot commented Sep 11, 2026

Copy link
Copy Markdown

CL-7757

@TheGreatAxios TheGreatAxios left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critic · Comment

After a parked ask_director is surfaced, list_agents fails closed until send_input or the ask is dropped.

Findings

No blocking findings.

  • src/subagent/agent-fleet.test.ts — close_agent and cancel are named clear-paths in CL-7757 but have no list_agents contract. interrupt_agent and send_input are covered; both close and cancel already drop the pending ask via settleCancelsAsks, so the gate should reopen, but that is inferred not tested.

Notes

  • Runtime gate lives in createListAgentsTool, not prompt-only. Error names send_input, the worker session id, question_id, and the question text.
  • First list surfaces once; identical snapshot errors; a new question_id is listable once. Yield wait does not stamp; TUI wake after sendInternalText does.
  • wait_agents stays mounted. Occupancy latch / mailbox-mail-drive / fleet-dry-drive / settleRunToIdle are untouched. list_agents remains outside doom-loop poll exemption.

@TheGreatAxios
TheGreatAxios force-pushed the cl-7757-answer-parked-ask_director-before-polling-list_agents branch from 5fe8d04 to af1eaf8 Compare September 11, 2026 22:27
@TheGreatAxios
TheGreatAxios merged commit 276f383 into main Sep 11, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant