Do not ask the operator to approve a path the sandbox will reject - #908
Merged
TheGreatAxios merged 2 commits intoSep 11, 2026
Merged
Conversation
TheGreatAxios
changed the title
Accept on an outside path still failed in the sandbox, so the overlay was dead. Deny at the gate instead; yolo still allows.
TheGreatAxios
force-pushed
the
cl-7635-do-not-ask-the-operator-to-approve-a-path-the-sandbox-will
branch
from
September 11, 2026 05:19
7c4e37b to
389ce25
Compare
TheGreatAxios
commented
Sep 11, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Looks good to merge after rebase. Interactive non-yolo escaped path-arg tools deny in decide() after the skipPermissions early-return and before any approval ask, matching path-escape at execution. Yolo still allows. authorizeCall/evaluate deny with asked === 0; shell outside-path ask path left intact. CHANGELOG keeps main bullets plus the authorize-time deny note.
TheGreatAxios
deleted the
cl-7635-do-not-ask-the-operator-to-approve-a-path-the-sandbox-will
branch
September 11, 2026 05:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interactive non-yolo outside-workspace path calls now fail closed before approval, preventing a dead approval overlay for calls path-escape will reject. Yolo / skip-permissions still allows outside-workspace path tools.
Verification: focused gate regression 2 pass; posix plugin suite 15 pass; lint + build pass. Full-check gaps are environmental (vendor semver typecheck and git-fixture timeouts). Independent critic verdict: ready, no blockers.
Fixes CL-7635