Bound the compaction summarizer and retry it once per failure class - #907
Merged
TheGreatAxios merged 1 commit intoSep 11, 2026
Conversation
TheGreatAxios
commented
Sep 11, 2026
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Looks good to merge. Summarizer now owns a 90s per-call cap (well under the director 600s) with harness retries disabled, and retries at most once per failure class — auth/provider yes, timeout never, which is the right trade for an inline reactor freeze. Tests pin the independent timeout and the spent-budget 401 case. CI is green.
TheGreatAxios
deleted the
cl-7694-compaction-summarizer-inherits-the-directors-600-s-timeout
branch
September 11, 2026 05:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
summarizerTimeoutMs) instead of inheriting the director's 600 stotalTimeoutMs, and the harness's built-in retry policy is disabled for this call so the summarizer owns its retry budget.credential_failure/401/403 re-reads the OAuth token store (ensureFreshInferenceSource) and updates the live source before retrying; provider 5xx andInternal error during token generationretry once; timeouts and aborts are never retried.systemNoticenaming the reason.summarizer_failuretelemetry withprovider,model,error_kind(first-party enum), andduration_ms.Verification
bun run checklint, typecheck, and build pass; 17 summarizer tests pass including a virtual-clock test proving the 30 s cap fires while the harness default remains 600 s.EPERMfailures (tests writing to/tmpor spawning git/processes); none touch the changed code.Fixes CL-7694