Fix root-path mentions minted from relative filenames in prose quotes - #902
Merged
TheGreatAxios merged 2 commits intoSep 11, 2026
Conversation
TheGreatAxios
commented
Sep 11, 2026
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review · Approve
Quoted prose no longer lets a mid-token / mint a root-level image mention; absolute paths inside quotes and unquoted scanning stay as before.
Findings
No findings.
Notes
bun test ./src/tui/image-attachments.test.ts— 18 pass, 0 fail- Commit subject/body style audit clean (
git log origin/main..HEADsubject/body; length>72 filters empty) - Scope:
src/tui/image-attachments.ts,src/tui/image-attachments.test.tsonly - GitHub blocked
--approveon this author's own PR; verdict here is still Approve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"notes/plan.png"no longer mints a root-level/plan.pngmentionVerification
bun run lint,bun run typecheck, andbun run buildpassbun run testpasses except sandbox-environmental failures (GPG, worktrees, sips) that reproduce on main; the new mention test passesFixes CL-7698