Skip to content

Fix root-path mentions minted from relative filenames in prose quotes - #902

Merged
TheGreatAxios merged 2 commits into
mainfrom
cl-7698-prose-quotes-with-a-relative-image-path-resolve-to-a-wrong
Sep 11, 2026
Merged

Fix root-path mentions minted from relative filenames in prose quotes#902
TheGreatAxios merged 2 commits into
mainfrom
cl-7698-prose-quotes-with-a-relative-image-path-resolve-to-a-wrong

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Collaborator

Summary

  • Path candidates inside non-path-shaped quoted prose must now open a new token, so "notes/plan.png" no longer mints a root-level /plan.png mention
  • Unquoted scanning is unchanged

Verification

  • bun run lint, bun run typecheck, and bun run build pass
  • bun run test passes except sandbox-environmental failures (GPG, worktrees, sips) that reproduce on main; the new mention test passes

Fixes CL-7698

@linear-code

linear-code Bot commented Sep 11, 2026

Copy link
Copy Markdown

CL-7698

@TheGreatAxios TheGreatAxios left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review · Approve

Quoted prose no longer lets a mid-token / mint a root-level image mention; absolute paths inside quotes and unquoted scanning stay as before.

Findings

No findings.

Notes

  • bun test ./src/tui/image-attachments.test.ts — 18 pass, 0 fail
  • Commit subject/body style audit clean (git log origin/main..HEAD subject/body; length>72 filters empty)
  • Scope: src/tui/image-attachments.ts, src/tui/image-attachments.test.ts only
  • GitHub blocked --approve on this author's own PR; verdict here is still Approve

@TheGreatAxios
TheGreatAxios merged commit 9cfe836 into main Sep 11, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant