Rate-limit concurrent mutating lane-overlap warnings - #891
Merged
TheGreatAxios merged 3 commits intoSep 11, 2026
Merged
Conversation
TheGreatAxios
commented
Sep 11, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Critic · Approve
isOverlapLive is pending_init/running only; warnedMutatingCwds emits at most once while any live writer remains; explore/plan/review/test do not participate.
No blocking or should-fix findings.
Notes
- Read-only coverage in tests is explore-only. Queued-writer test with capacity 1 never admits B while A is live.
TheGreatAxios
commented
Sep 11, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review · Approve
Lane-overlap warnings fire once per mutating cwd wave, skip declared read-only roles, and use session-store liveness.
No findings.
Notes
GitHub blocks approve on own PRs, so this is a comment with an approve verdict.
TheGreatAxios
force-pushed
the
cl-7649-deduplicate-concurrent-lane-overlap-conflict-logs
branch
from
September 11, 2026 03:09
687238c to
6be62de
Compare
Cancel can stamp finishedAt before the run promise settles and reaches finally, so an activeLanes map entry alone was enough to emit concurrent-lane-overlap against a worker that was already terminal. Overlap checks now trust pending_init/running from the session store, prune terminal or absent map entries opportunistically, and keep the finally delete.
Shared-cwd concurrent-lane-overlap noise was one record per peer with no filter for explore/plan/review/test directors. Emit at most one conflict when a cwd wave first has two live mutating writers, suppress declared read-only peers, and clear the wave flag once no live writer remains. No age TTL or map sweep.
TheGreatAxios
force-pushed
the
cl-7649-deduplicate-concurrent-lane-overlap-conflict-logs
branch
from
September 11, 2026 03:11
6be62de to
77440c3
Compare
TheGreatAxios
deleted the
cl-7649-deduplicate-concurrent-lane-overlap-conflict-logs
branch
September 11, 2026 03:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
concurrent-lane-overlapconflict per shared-cwd mutating wave, and skips declared read-only peers (explore/plan/review/test).pending_init/runningas liveness so a cancelled but unsettled lane does not warn;finallystill deletes the map entry. Queued workers are not inserted until admission starts them. Parked live writers stay in the map on purpose.Verification
bun run typecheckandbun run buildpassbun run checkexits 1 on four pre-existing failures outside this diff (assembleChatAgentstill mockscreateOptimizedContextStorewhile production usescreateSessionStores; twocreateOptimizedContextStoretests fail independently)Fixes CL-7649