Parse quoted image path mentions without losing whitespace or false-positive matches - #889
Merged
Merged
Conversation
TheGreatAxios
commented
Sep 11, 2026
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review · Approve
Quoted image-path mentions keep inner whitespace; contractions and prose quotes do not steal wrappers.
No findings.
Notes
Critic timed out twice on xAI; this is the orchestrator read of origin/main...origin/cl-7666-image-path-wrappers only (not the dirty local tree). GitHub blocks approve on own PRs, so this is a comment with an approve verdict.
Unquoted unmatched openers stay line-bounded. Quoted file:// decodes; quoted backslashes stay literal.
TheGreatAxios
commented
Sep 11, 2026
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Critic · Approve
Director timed out; parent re-read the three-dot diff. scanImagePathLine + looksLikeQuotedImagePath + quoted vs unquoted normalize.
No blocking or should-fix findings.
Notes
don't/what'sskip'after a word char; prose"look at /tmp/shot.png"still finds the absolute path.- Relative unquoted paths with spaces still rejected (
./relative path.png→ []).
TheGreatAxios
force-pushed
the
cl-7666-image-path-wrappers
branch
3 times, most recently
from
September 11, 2026 03:16
334cec0 to
29f1028
Compare
macOS screenshot paths often arrive single-quoted with spaces and narrow no-break spaces; the old whole-prompt regex could not own a balanced wrapper, so those mentions never became attachments.
Contractions were pairing with later path quotes, and prose-quoted sentences were resolving as bogus relative paths. Only treat path- shaped wrappers as wrappers, and still find absolute paths inside ordinary quotes.
TheGreatAxios
force-pushed
the
cl-7666-image-path-wrappers
branch
from
September 11, 2026 03:19
29f1028 to
6f8bc42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
bun run typecheck,bun run build, and 29/29 focused tests for this change passbun run checkpasses lint, typecheck, and build; the full test run hits 4 pre-existing failures unrelated to this change (createOptimizedContextStoretorn-tail/hook,assembleChatAgentEROFS)Fixes CL-7666