Remove the inert --force CLI flag - #888
Merged
Merged
Conversation
TheGreatAxios
commented
Sep 11, 2026
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Critic · Request changes
Parser, onboarding argv re-inject, and evals no longer carry --force. Remaining --force hits are git/rm/worktree, not the CLI flag.
Findings
docs/PRODUCT.md:86— stale picker-filter instruction now errors. Same file already says the picker includes completed sessions.
TheGreatAxios
commented
Sep 11, 2026
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review · Request changes
--force is gone from CLI parsing, Config, help, evals, and tests. PRODUCT.md still tells operators to pass it.
Findings
docs/PRODUCT.md:86— Resume section still says pass--forceto include failed and done. That now hitsunrecognized flaginloadConfig. Other docs andCLI_HELP_TEXTwere cleaned.
Notes
GitHub blocks request-changes on own PRs, so this is a comment with that verdict.
TheGreatAxios
force-pushed
the
cl-7674-remove-force
branch
2 times, most recently
from
September 11, 2026 03:16
d174007 to
048b65e
Compare
The flag was parsed into Config but never changed resume or run behavior. Reject it as unrecognized and drop the dead field.
TheGreatAxios
force-pushed
the
cl-7674-remove-force
branch
3 times, most recently
from
September 11, 2026 03:21
0b8c0b5 to
acf3663
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed the inert
--forceCLI plumbing (Config/UnconfiguredConfig/help/onboarding/eval scripts/fixtures) and updated ARCHITECTURE/IMPLEMENTATION/TUI/CHANGELOG.PRODUCT.mdis intentionally untouched (owned by CL-7650).Verification
bun run typecheck- exit 0bun run check- blocked by known pre-existing main failures (unrelated to this change):createOptimizedContextStore load > the next write heals a torn base tail so reload is stablecreateOptimizedContextStore unpublished rewrite > git commit failure after rewrite lands keeps load on HEADassembleChatAgent > omits evidence archive when no holder is providedassembleChatAgent > getWorkdir and getCompactor run at buildAgent time, not assemble timeFixes CL-7674