Skip to content

Remove the inert --force CLI flag - #888

Merged
TheGreatAxios merged 1 commit into
mainfrom
cl-7674-remove-force
Sep 11, 2026
Merged

Remove the inert --force CLI flag#888
TheGreatAxios merged 1 commit into
mainfrom
cl-7674-remove-force

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Collaborator

Summary

Removed the inert --force CLI plumbing (Config/UnconfiguredConfig/help/onboarding/eval scripts/fixtures) and updated ARCHITECTURE/IMPLEMENTATION/TUI/CHANGELOG. PRODUCT.md is intentionally untouched (owned by CL-7650).

Verification

  • bun run typecheck - exit 0
  • Focused suite: 159 pass, 0 fail across config/session/eval/exec tests
  • bun run check - blocked by known pre-existing main failures (unrelated to this change):
    • createOptimizedContextStore load > the next write heals a torn base tail so reload is stable
    • createOptimizedContextStore unpublished rewrite > git commit failure after rewrite lands keeps load on HEAD
    • assembleChatAgent > omits evidence archive when no holder is provided
    • assembleChatAgent > getWorkdir and getCompactor run at buildAgent time, not assemble time

Fixes CL-7674

@linear-code

linear-code Bot commented Sep 11, 2026

Copy link
Copy Markdown

CL-7674

@TheGreatAxios TheGreatAxios left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critic · Request changes

Parser, onboarding argv re-inject, and evals no longer carry --force. Remaining --force hits are git/rm/worktree, not the CLI flag.

Findings

  • docs/PRODUCT.md:86 — stale picker-filter instruction now errors. Same file already says the picker includes completed sessions.

@TheGreatAxios TheGreatAxios left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review · Request changes

--force is gone from CLI parsing, Config, help, evals, and tests. PRODUCT.md still tells operators to pass it.

Findings

  • docs/PRODUCT.md:86 — Resume section still says pass --force to include failed and done. That now hits unrecognized flag in loadConfig. Other docs and CLI_HELP_TEXT were cleaned.

Notes

GitHub blocks request-changes on own PRs, so this is a comment with that verdict.

@TheGreatAxios
TheGreatAxios force-pushed the cl-7674-remove-force branch 2 times, most recently from d174007 to 048b65e Compare September 11, 2026 03:16
The flag was parsed into Config but never changed resume or run
behavior. Reject it as unrecognized and drop the dead field.
@TheGreatAxios
TheGreatAxios force-pushed the cl-7674-remove-force branch 3 times, most recently from 0b8c0b5 to acf3663 Compare September 11, 2026 03:21
@TheGreatAxios
TheGreatAxios merged commit dfe1856 into main Sep 11, 2026
9 checks passed
@TheGreatAxios
TheGreatAxios deleted the cl-7674-remove-force branch September 11, 2026 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant