Correct Grok model-family policy documentation - #880
Merged
TheGreatAxios merged 1 commit intoSep 11, 2026
Merged
Conversation
TheGreatAxios
commented
Sep 10, 2026
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Critic · Approve (intent)
Corrects ARCHITECTURE.md so Grok shares the five-minute stall timeout and default tool-only nudge; finish bias stays leaf-only.
GitHub blocked --approve (own PR). Verdict: ready to merge.
Findings
No findings.
Notes
- Docs-only: single file
docs/ARCHITECTURE.md(+1/−1); line ref:48matchesDEFAULT_POLICY. - Code truth:
GROK_POLICY.subAgentStallTimeoutMs/toolOnlyTurnNudgeAtalias defaults (5 * 60_000, 25);applyGrokFinishBias && !orchestratorat resolve. Tests cover shared stall and leaf-vs-orchestrator bias. - Kimi/default discussion preserved; no behavior change.
TheGreatAxios
commented
Sep 11, 2026
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review · Approve
ARCHITECTURE.md Grok stall/timeout sentence matches GROK_POLICY sharing the default five-minute sub-agent stall timeout and tool-only nudge threshold.
No findings.
Notes
GitHub blocks approve on own PRs, so this is a comment with an approve verdict.
TheGreatAxios
commented
Sep 11, 2026
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Critic · Approve
GROK_POLICY.subAgentStallTimeoutMs equals DEFAULT_POLICY (5 minutes). applyGrokFinishBias remains leaf-only. Existing model-family-policy tests already lock this.
No findings.
TheGreatAxios
force-pushed
the
cl-7659-architecturemd-still-claims-a-90s-grok-stall-timeout
branch
from
September 11, 2026 03:08
4e1ee91 to
bf2f729
Compare
TheGreatAxios
force-pushed
the
cl-7659-architecturemd-still-claims-a-90s-grok-stall-timeout
branch
from
September 11, 2026 03:10
bf2f729 to
6d0124f
Compare
TheGreatAxios
deleted the
cl-7659-architecturemd-still-claims-a-90s-grok-stall-timeout
branch
September 11, 2026 03:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct ARCHITECTURE.md Grok model-family policy docs: Grok shares the five-minute sub-agent stall timeout (not 90s) and tool-only nudge threshold;
applyGrokFinishBiasremains leaf-only and is excluded from orchestrators. Line reference updated tomodel-family-policy.ts:48.Verification
git diff --checkexited 0bun run check: lint, typecheck, and build passed; full suite exited 1 with 5 failures unrelated to this docs-only edit (initTemporaryGitRepofixture timeout;createOptimizedContextStoretorn-base heal;createOptimizedContextStoreunpublished rewrite;assembleChatAgentomits evidence archive;assembleChatAgentgetWorkdir/getCompactor). Failures observed on this worktree afterbun install; not caused by the ARCHITECTURE.md change.Fixes CL-7659