Show failed file-tool errors on the collapsed transcript line - #870
Merged
TheGreatAxios merged 1 commit intoSep 10, 2026
Merged
Conversation
Failed reads painted a cross and the path only, so a missing blob or file looked identical until the row was expanded. The error belongs on the collapsed line with the mark.
TheGreatAxios
commented
Sep 10, 2026
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Critic · Comment
Failed file-tool rows put the tool-result error on the collapsed transcript line; success rows stay path plus mark.
Findings
No findings.
Notes
Merge-ready against CL-7621. resultAddendum now forwards result.text (abbreviated) onto stat, which toolSentenceLines already paints. The two missing-file cases and the success-row case are covered in src/tui/tool-rows.test.ts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Failed
read_file(and equivalent file-tool) rows show the error text on the collapsed transcript line, not only a failure mark. Success rows are unchanged.Without the error, a missing
tool-output://blob or missing path looks like a wedged session: the tool failed, the operator cannot see why, and the model retries the same URI.×.read_filestill shows the path and✓, not the file body.Verification
bun run typecheck,bun run build, andbun run testpassbun run checkpassesbun test src/tui/tool-rows.test.tscovers missing blob, missing file, and unchanged success rowsFixes CL-7621