Skip to content

Show failed file-tool errors on the collapsed transcript line - #870

Merged
TheGreatAxios merged 1 commit into
mainfrom
cl-7621-show-the-error-text-on-a-failed-read_file-in-the-tui
Sep 10, 2026
Merged

Show failed file-tool errors on the collapsed transcript line#870
TheGreatAxios merged 1 commit into
mainfrom
cl-7621-show-the-error-text-on-a-failed-read_file-in-the-tui

Conversation

@TheGreatAxios

@TheGreatAxios TheGreatAxios commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

Failed read_file (and equivalent file-tool) rows show the error text on the collapsed transcript line, not only a failure mark. Success rows are unchanged.

Without the error, a missing tool-output:// blob or missing path looks like a wedged session: the tool failed, the operator cannot see why, and the model retries the same URI.

  • The collapsed line surfaces the same model-visible error payload (flattened to the log-preview budget when long).
  • Missing blob URI and missing filesystem path both render the error plus the path subject and ×.
  • Success read_file still shows the path and , not the file body.

Verification

  • bun run typecheck, bun run build, and bun run test pass
  • bun run check passes
  • bun test src/tui/tool-rows.test.ts covers missing blob, missing file, and unchanged success rows

Fixes CL-7621

Failed reads painted a cross and the path only, so a missing blob or file looked identical until the row was expanded. The error belongs on the collapsed line with the mark.
@linear-code

linear-code Bot commented Sep 10, 2026

Copy link
Copy Markdown

CL-7621

@TheGreatAxios TheGreatAxios left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critic · Comment

Failed file-tool rows put the tool-result error on the collapsed transcript line; success rows stay path plus mark.

Findings

No findings.

Notes

Merge-ready against CL-7621. resultAddendum now forwards result.text (abbreviated) onto stat, which toolSentenceLines already paints. The two missing-file cases and the success-row case are covered in src/tui/tool-rows.test.ts.

@TheGreatAxios
TheGreatAxios merged commit cbdd3ae into main Sep 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant