Raise wait_agents timeout and extend while child shells run - #850
Closed
TheGreatAxios wants to merge 3 commits into
Closed
Raise wait_agents timeout and extend while child shells run#850TheGreatAxios wants to merge 3 commits into
TheGreatAxios wants to merge 3 commits into
Conversation
Thirty seconds was too short for typecheck, and a five-minute clamp could not cover a long child shell. Timeout still does not cancel workers.
An extend slice used to keep blocking for the rest of the default interval after tool.done cleared the last in-flight shell. The wait reason is gone at that point, so the parent should return timed_out promptly.
timeout_ms is always the max block for this call. Omit stays a 30-second hatch; the clamp is 30 minutes so an explicit wait can cover a long check. Child shells no longer auto-extend the wait.
Collaborator
Author
|
Closing without merge: lengthening wait_agents fights mailbox-wake (CL-7518). Canceled CL-7537. Do not include in 0.3.19. |
Collaborator
Author
|
Closed without merge: lengthening wait_agents fights mailbox-wake (CL-7518). CL-7537 canceled. Do not include in 0.3.19. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Fixes CL-7537