Skip to content

Resume operator approval on the live agent - #845

Merged
TheGreatAxios merged 7 commits into
mainfrom
cl-7532-approval-resume-stalls-operator-approval-does-not-reliably
Sep 10, 2026
Merged

Resume operator approval on the live agent#845
TheGreatAxios merged 7 commits into
mainfrom
cl-7532-approval-resume-stalls-operator-approval-does-not-reliably

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Collaborator

Summary

  • Operator approve/decline resumes on the live agent, keyed by correlation id, not a snapshotted instance.
  • send plus approval-resume stay inside runWhileAgentBusy so reloadIfIdle cannot close the agent while the overlay is up.
  • Overlay start captures delivery generation; /clear and interrupt bump it so a later accept cannot land in a rebuilt session.

Verification

  • bun run typecheck, bun run build, and bun run test pass
  • bun run check passes

Fixes CL-7532
Changelog: bug

@linear-code

linear-code Bot commented Sep 9, 2026

Copy link
Copy Markdown

CL-7532

@TheGreatAxios TheGreatAxios left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

independent critic found no remaining blocking stalls. Interrupt during overlay now bumps delivery generation before close/rebuild so later accept/decline cannot land on the rebuilt agent. File-for-later: add a lifecycle test that interrupt() itself calls bump (being added as a follow-up).

@TheGreatAxios
TheGreatAxios force-pushed the cl-7532-approval-resume-stalls-operator-approval-does-not-reliably branch 2 times, most recently from ad8c9a6 to 2ed56eb Compare September 10, 2026 01:44
/clear during the permission overlay bumped generation after handle
started, but the TUI recaptured at deliver time so an accept still
injected the approved decision into the empty session.
Interrupt rebuilt the agent while the permission overlay stayed
open, so a later accept or decline still saw a current generation
and delivered into the new agent. Bump delivery generation on
interrupt the same way session rotation does.
@TheGreatAxios
TheGreatAxios force-pushed the cl-7532-approval-resume-stalls-operator-approval-does-not-reliably branch from 6e9d834 to 9421101 Compare September 10, 2026 02:49
@TheGreatAxios
TheGreatAxios merged commit df0b168 into main Sep 10, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant