Clock idle landing snow from the landing's own timer - #788
Merged
TheGreatAxios merged 8 commits intoSep 5, 2026
Merged
Conversation
The monitor stays quiet when idle, which is correct for turn chrome. The landing is idle by definition and still wants motion, so it owns a mount-scoped timer for its lifetime. Driving the mark from the renderer FRAME event was rejected because FRAME follows dirty rows and self-starves under throttle.
Paint-function tests stayed green while snow was unreachable. These assert the real mount timer, its teardown, and the reduced-motion hook.
TheGreatAxios
commented
Sep 4, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review · Approve
Idle landing snow is clocked by the landing's own 33ms timer, scoped to mount and teardown, and reduced-motion never starts it.
No findings.
TheGreatAxios
commented
Sep 4, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Critic · Comment
The two-commit branch matches the brief. TUI.md records the landing as the pre-session frame owner. Tests pin reduced-motion, mount-path snow motion, and timer teardown.
No findings.
A hardcoded delay would still report no armed timer if the product cadence moved while reduced-motion skip stayed broken.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setIntervalfor mark snow; the renderer still stops on session idle.The landing is idle by definition, so a session-idle frame stop cannot paint snow. The landing's own timer is the frame source for that surface only.
Verification
bun run typecheckexits 0bun run buildexits 0bun test ./src/tui/landing.test.ts ./src/tui/mark-anim.test.ts ./src/tui/render-loop.test.ts— 45 pass, 0 failbun run checkfails 4 overlay-body tests because this worktree path containssession(pre-sessionin the branch name); those tests do not exercise this diff. CI cwd is the repo root.Fixes CL-5737