Clear pending images with the first idle Ctrl+C - #786
Conversation
TheGreatAxios
left a comment
TheGreatAxios
left a comment
There was a problem hiding this comment.
critic
Meets CL-5738. Idle first Ctrl+C clears prompt text and pending attachments; attachments-only does not arm the quit window; empty prompt with no attachments still arms; busy interrupt does not drop attachments. clearPendingAttachments unlinks ephemeralPath only.
No blocking defects on 61c04f56.
TheGreatAxios
left a comment
TheGreatAxios
left a comment
There was a problem hiding this comment.
critic · Comment
Idle first Ctrl+C clears prompt and pending images; busy interrupt keeps attachments; operator path is never unlinked.
No findings.
TheGreatAxios
left a comment
TheGreatAxios
left a comment
There was a problem hiding this comment.
Review · Comment
Idle Ctrl+C clears prompt text and pending attachments; attachments-only does not arm quit; clearPendingAttachments unlinks ephemeralPath only.
No findings. Cannot --approve as the PR author.
RoR: git log --oneline 5a722735..61c04f56 is one commit; git diff 5a722735...61c04f56 --stat is 5 files, no Bin; subject and body under 72 with no prefix or ticket ID.
61c04f5 to
168d538
Compare
TheGreatAxios
left a comment
TheGreatAxios
left a comment
There was a problem hiding this comment.
critic · Comment
Follow-up tests close prompt-text arming (prompt-slash-exit.test.ts:279), ENOENT swallow (:357), both-fields unlink (:366), and the idle attachment-clear keybindings probe (keybindings.test.ts:522).
No findings.
TheGreatAxios
left a comment
TheGreatAxios
left a comment
There was a problem hiding this comment.
Review · Comment
Idle Ctrl+C clears prompt text and pending attachments; attachments-only does not arm quit; only ephemeralPath is unlinked.
No findings. Prior arming, ENOENT, keybindings probe, and both-fields unlink notes are closed. Cannot --approve as the PR author.
RoR: git log --oneline cl-5740..cl-5738 is two commits; git diff --stat is 6 files, no Bin; subjects and bodies under 72 with no prefix or ticket ID.
168d538 to
28baead
Compare
018257e to
947426d
Compare
Idle Ctrl+C used to wipe prompt text but leave pending attachments on the notice row. Clear both, and unlink only files Corbits created (ephemeralPath) so operator path-mention files stay on disk.
Idle Ctrl+C already unlinks Corbits-created ephemeralPath files. Quit via dispose or a second Ctrl+C skipped that path, so clipboard temp files stayed on disk. Operator-owned path mentions stay untouched.
947426d to
072bcd9
Compare
1 participant
Summary
Verification
bun run checkpasses (lint, typecheck, build, 6164 tests)bun test ./src/tui/prompt-slash-exit.test.tscovers attachments surviving a clear and busy interrupt keeping themFixes CL-5738