Register the active run for headless exec so signals finalize it - #781
Merged
TheGreatAxios merged 1 commit intoSep 5, 2026
Conversation
TheGreatAxios
commented
Sep 4, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Critic · Comment
Headless exec registers the active run after a successful running persist and terminalizes through finalizeRunState.
No findings.
TheGreatAxios
commented
Sep 4, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Greybeard · Comment
Exec persist is the owning layer for registering the active-run handle. Process signal handlers in index.ts already finalize a registered run; a second exec-specific handler would duplicate that path.
No findings.
TheGreatAxios
commented
Sep 4, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review · Approve
Headless exec registers the active run so process signals finalize run.json.
No findings.
GitHub forbids self-approve on this PR; verdict is approve as a comment.
Process signal handlers already finalize the registered run. Headless exec wrote running to run.json but never registered, so a supervisor stop left the session looking live.
TheGreatAxios
force-pushed
the
cl-7332-headless-exec-leaves-run-state-stale-after-process-signal
branch
from
September 5, 2026 05:38
857ca69 to
259553b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
corbits execregisters the process-global active run after a successful running persist, so SIGINT, SIGTERM, and SIGHUP finalizerun.jsonasfailedwithfinishedAtandterminated by <signal>.finalizeRunState. An in-flight running persist does not resurrect the handle after the run has finished.Verification
bun run typecheck,bun run build, andbun run testpassbun run checkexits 0 (6162 pass, 0 fail)Fixes CL-7332