Set session stopReason from typed ForcedStopReason only - #657
Merged
Conversation
stopReasonFromReport was a second source of truth that fabricated reasons from report prose. Thread the structured value from runSubAgent through SessionStore.complete instead.
TheGreatAxios
added a commit
that referenced
this pull request
Aug 27, 2026
stopReasonFromReport was a second source of truth that fabricated reasons from report prose. Thread the structured value from runSubAgent through SessionStore.complete instead.
TheGreatAxios
added a commit
that referenced
this pull request
Aug 27, 2026
stopReasonFromReport was a second source of truth that fabricated reasons from report prose. Thread the structured value from runSubAgent through SessionStore.complete instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ForcedStopReasonfromrunSubAgentthroughSessionStore.completeinstead of fabricating reasons from report prose.stopReasonFromReportas a second source of truth.Verification
bun run typecheck,bun run build, andbun run testpassFixes CL-7006