Proxy Codex apply_patch onto Corbits file tools - #505
Merged
TheGreatAxios merged 7 commits intoAug 23, 2026
Merged
Conversation
Why: Codex-trained models call apply_patch from pinned instructions, but Corbits only advertised write_file/edit_file/delete_file. That dialect mismatch hurts Codex evals versus Codex-native harnesses. What changed: Codex-only apply_patch proxy (parse envelope, forward through posix write/edit/delete), shared product-mutation ownership, primary deny unchanged, IMPLEMENT/DOCS allowlists, docs leaves refuse Delete/Move via allowDelete. Bridge text left for the next stacked change. Test plan: bun test on codex-apply-patch, codex-tool-proxies, codex-tool-mount, product-mutation-tools, tool-sets; bun run typecheck.
createUpdatePlanProxy called runTool("manage_tasks", ...), but runTool
forwards only to posixTools, which has no manage_tasks handler — every
update_plan call errored with "unknown tool: manage_tasks". Give
createCodexToolProxies its own runManageTasks callback and wire each
mount site (tools.ts, subagent/run.ts) to the same manage_tasks logic
their stringTool handler already uses. Also fix requireOk's hardcoded
"apply_patch failed" label to use the actual label argument.
Tests: dropped the manage_tasks special case from the apply_patch mock
recorder (posixTools has no such handler, so it now falls through to
the accurate "unknown tool" branch), and added coverage that dispatches
through the real parseManageTasksArgs/applyManageTasks pair and through
the real createAgentToolset mount with unstubbed posixTools — both
would have caught the dead dispatch.
Empty createPosixTools stub hid write_file/edit_file/delete_file, so the primary DIY-remains expects could never pass. Use the real mount like the update_plan e2e case.
TheGreatAxios
force-pushed
the
cl-6696-proxy-codex-native-tool-names-onto-corbits-tools
branch
from
August 23, 2026 00:36
17b95cf to
00ab2d9
Compare
2 tasks
TheGreatAxios
added a commit
that referenced
this pull request
Aug 27, 2026
…ol-names-onto-corbits-tools Proxy Codex apply_patch onto Corbits file tools
TheGreatAxios
added a commit
that referenced
this pull request
Aug 27, 2026
…ol-names-onto-corbits-tools Proxy Codex apply_patch onto Corbits file tools
TheGreatAxios
deleted the
cl-6696-proxy-codex-native-tool-names-onto-corbits-tools
branch
August 27, 2026 23:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apply_patchproxy that parses the Codex patch envelope and forwards through posixwrite_file/edit_file/delete_file(permission plugins included).apply_patchvia allowlists. Docs leaves refuse Delete/Move whendelete_fileis not allowed.apply_patchlike the write trio.Verification
bun run typecheckand pre-commit build passcodex-apply-patch,codex-tool-proxies,codex-tool-mount,product-mutation-tools,tool-setstests passbun run testrunning / to confirm on CIFixes CL-6696