feat(shell): default 120s foreground run_shell timeout - #1087
Merged
TheGreatAxios merged 2 commits intoSep 16, 2026
Merged
TheGreatAxios merged 2 commits into
TheGreatAxios merged 2 commits into
Conversation
Summary Foreground run_shell now times out at 120s when timeout is omitted. A positive per-call timeout is the bound with no ceiling. Background run_shell stays unbounded unless timeout is set. Watchdog arms on the effective foreground timeout plus 1s slack. Verification bun test ./src/plugins/shell-guard-plugin.test.ts ./src/tui/tool-execution-watchdog.test.ts ./src/settings.test.ts ./src/prompts.test.ts ./src/shell/background-shell.test.ts ./src/agent/background-shell-tool.test.ts ./src/agent/posix-tool-plugins.test.ts bun run typecheck bun run check
Summary run_shell schema timeout copy now says the default is foreground-only and to omit timeout on background:true. Advertise uses the same default as resolveShellTimeoutMs when only maxTimeoutMs is set. Verification bun test ./src/plugins/shell-guard-plugin.test.ts bun run typecheck bun run check
TheGreatAxios
deleted the
cl-8019-default-2-min-foreground-run_shell-timeout-background-job
branch
September 16, 2026 02:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_shelldefaults to a 120s timeout (schema default120000ms); callers can still pass an unbounded per-call timeout.Verification
bun run typecheck,bun run build, andbun run testpassFixes CL-8019