fix(tui): report reconnecting instead of unknown tool for promoted-but-unmounted calls - #1082
Merged
TheGreatAxios merged 4 commits intoSep 16, 2026
Conversation
This was referenced Sep 16, 2026
…t-unmounted calls Summary: the live call gate now distinguishes a registry miss on a gate-activated (promoted) name — its server dropped between search and call — from a never-activated miss. Activated misses return a reconnecting/retry-shortly error; plain misses keep the exact unknown tool string. Both production gates (TUI session, exec) pass the activation predicate; the wire hold-off machinery is untouched. Verification: bun test on dynamic-tool-runner, assemble-runtime, tool-search, exec runner suites plus src/tui/runner (87 pass, 0 fail); oxfmt/oxlint clean on changed files; tsc shows only the pre-existing vendor semver error (proven on pristine HEAD via stash).
Strip a single leading <segment>. prefix on registry miss and retry the lookup, so harness-namespaced calls such as default.mcp__linear__list_releases dispatch through the gate. Miss paths keep the exact reconnecting and unknown-tool strings with the original name.
A harness-namespaced call (default.<stripped>) misses the registry under its original name even when <stripped> was activated. Check isActivated with the stripped form too so an activated-but-unmounted tool reports reconnecting instead of unknown tool. Miss-branch strings still use the original name; never-activated misses keep the exact unknown-tool string. Adds keeper tests: dotted registration wins over bare suffix, prefixed activated miss reports reconnecting under the original name, gate-reject on a normalized call reports the stripped name.
TheGreatAxios
force-pushed
the
cl-8021-promoted-but-unmounted-tools-fail-at-call-time-tool_search
branch
from
September 16, 2026 02:08
d0a1dcf to
def6dbf
Compare
TheGreatAxios
enabled auto-merge (squash)
September 16, 2026 02:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: the live call gate now distinguishes a registry miss on a gate-activated (promoted) name — its server dropped between search and call — from a never-activated miss. Activated misses return a reconnecting/retry-shortly error; plain misses keep the exact unknown tool string. Both production gates (TUI session, exec) pass the activation predicate; the wire hold-off / flushPromotions machinery is untouched.
Verification: red-then-green regression test in src/tui/dynamic-tool-runner.test.ts; bun test on dynamic-tool-runner, assemble-runtime, tool-search, exec runner suites plus src/tui/runner (87 pass, 0 fail); oxfmt/oxlint clean on changed files; tsc shows only the pre-existing vendor semver error (proven on pristine HEAD via stash).
Fixes CL-8021