Repository navigation
Add failure-only completion callbacks - #231
Closed
ianmacartney wants to merge 1 commit into
Closed
ianmacartney wants to merge 1 commit into
ianmacartney wants to merge 1 commit into
Conversation
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
commit: |
ianmacartney
force-pushed
the
ian/workpool-test-cleanup
branch
from
September 5, 2026 07:31
4ba7dd3 to
b875de4
Compare
ianmacartney
force-pushed
the
ian/on-failure
branch
4 times, most recently
from
September 5, 2026 21:34
f5dac21 to
b76f791
Compare
ianmacartney
marked this pull request as ready for review
September 9, 2026 02:41
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 8 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
ianmacartney
force-pushed
the
ian/on-failure
branch
from
September 9, 2026 03:32
b76f791 to
3859830
Compare
reeceyang
approved these changes
Sep 10, 2026
Member
Author
|
likely replacing with #237 (but I haven't reviewed that one as carefully yet) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copying the approach from #175 but scoping it down to the simpler case of onFailure, which has no transactional complexity.
Intended uses: