Skip to content

feat: Add app and API versions - #32

Merged
gcgoncalves merged 2 commits into
mainfrom
version-popover
Aug 14, 2026
Merged

feat: Add app and API versions#32
gcgoncalves merged 2 commits into
mainfrom
version-popover

Conversation

@gcgoncalves

Copy link
Copy Markdown
Contributor
Pointing to API v1.0.7 Pointing to API v1.0.0
Screenshot 2026-08-14 at 21 34 04 Screenshot 2026-08-14 at 21 33 28

Signed-off-by: Gabriel Costa <gabrielcg@proton.me>

@a-effort a-effort left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🚀

Non-blocking notes:

vite.config.ts / vitest.config.ts: duplicated define block

The identical define block is added to both config files. If a third build-time constant is introduced later it must be remembered in two places. Consider extracting the shared constants into a small helper (e.g. build-constants.ts) that both configs import, or having vitest.config.ts import and spread the relevant portion of vite.config.ts.

Header.tsx hover card is mouse-only**

<HoverCardTrigger asChild>
  <span className="hidden cursor-default ...">
    v{__APP_VERSION__}
  </span>
</HoverCardTrigger>

Radix does compose onFocus/onBlur onto the child via asChild, so the event wiring is fine, but a plain <span> has no tabIndex and is not in the tab order, so keyboard users can never trigger the popover. Adding tabIndex={0} to the span (or swapping it for an inline-styled <button>) would make it keyboard-accessible.

hover-card.tsx w-72 default:

The component defaults to w-72 in its className, but the only call site immediately overrides it with className="w-auto". No change needed, just fyi if this component is reused elsewhere.

Signed-off-by: Gabriel Costa <gabrielcg@proton.me>
@gcgoncalves
gcgoncalves requested a review from a-effort August 14, 2026 21:32
@gcgoncalves
gcgoncalves merged commit c512c3a into main Aug 14, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants