feat: Add app and API versions - #32
Conversation
gcgoncalves
commented
Aug 14, 2026
| Pointing to API v1.0.7 | Pointing to API v1.0.0 |
|---|---|
![]() |
![]() |
Signed-off-by: Gabriel Costa <gabrielcg@proton.me>
5da2a4a to
16c6f8f
Compare
There was a problem hiding this comment.
Great job! 🚀
Non-blocking notes:
vite.config.ts / vitest.config.ts: duplicated define block
The identical define block is added to both config files. If a third build-time constant is introduced later it must be remembered in two places. Consider extracting the shared constants into a small helper (e.g. build-constants.ts) that both configs import, or having vitest.config.ts import and spread the relevant portion of vite.config.ts.
Header.tsx hover card is mouse-only**
<HoverCardTrigger asChild>
<span className="hidden cursor-default ...">
v{__APP_VERSION__}
</span>
</HoverCardTrigger>Radix does compose onFocus/onBlur onto the child via asChild, so the event wiring is fine, but a plain <span> has no tabIndex and is not in the tab order, so keyboard users can never trigger the popover. Adding tabIndex={0} to the span (or swapping it for an inline-styled <button>) would make it keyboard-accessible.
hover-card.tsx w-72 default:
The component defaults to w-72 in its className, but the only call site immediately overrides it with className="w-auto". No change needed, just fyi if this component is reused elsewhere.
Signed-off-by: Gabriel Costa <gabrielcg@proton.me>

