-
Notifications
You must be signed in to change notification settings - Fork 1
feature: Performance improvements #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gcgoncalves
wants to merge
4
commits into
main
Choose a base branch
from
performance-improve
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
a705dfa
feature: Performance improvements
gcgoncalves 112a170
Fix caching issues
gcgoncalves 3ce67c2
fix: harden route chunk loading and disable auto request decompression
gcgoncalves 5761b10
fix: harden error boundary, cache scoping, and route chunk loading
gcgoncalves File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| // Location: ./client/server/src/plugins/compress.ts | ||
| // Copyright contributors to the MCP-CONTEXT-FORGE project | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| // | ||
| // Global response compression (brotli > gzip > deflate, by Accept-Encoding). | ||
| // Must be registered before staticPlugin — @fastify/compress's global hook | ||
| // only wraps replies from routes registered after it. SSE routes are exempt | ||
| // automatically: proxy-sse.ts calls reply.hijack(), which skips the onSend | ||
| // chain this plugin hooks into. | ||
| // | ||
| // globalDecompression: false — { global: true } alone also auto-decompresses | ||
| // request bodies fleet-wide (undocumented decompression-bomb surface). | ||
|
|
||
| import fastifyCompress from "@fastify/compress"; | ||
| import type { FastifyInstance } from "fastify"; | ||
| import fp from "fastify-plugin"; | ||
|
|
||
| export default fp( | ||
| async function compressPlugin(fastify: FastifyInstance) { | ||
| await fastify.register(fastifyCompress, { global: true, globalDecompression: false }); | ||
| }, | ||
| { name: "compressPlugin" }, | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
server/src/plugins/static.ts:38The 1-year immutable cache header is applied to the whole static root, not just the hashed
/assets/*prefix. Direct requests toindex.html(or any non-hashed file copied frompublic/) get cached immutably for a year, so after the next deploy (which wipes and regenerates hashed chunk names) clients can get stuck on a stale shell referencing chunks that no longer exist.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for flagging this. I think it's actually already handled: the header is only applied when the resolved file path contains /assets/:
index.htmland anything copied verbatim frompublic/don't match that condition, so they fall through with no Cache-Control header set (i.e.@fastify/static's default, effectively no long-term caching). It's not being applied to the whole static root.That said, you were right about the underlying risk: this exact bug (unconditional
maxAge: "1y", immutable: trueon the whole root) existed one commit back, beforeFix caching issuesreplaced it with this scopedsetHeaderscheck. Might be worth a re-review/resolve on this thread since it looks like the comment landed on the pre-fix version.