Skip to content

fix: add npm overrides to resolve Snyk vulnerabilities (0.1.4) - #116

Open
cs-raj wants to merge 3 commits into
mainfrom
fix/snyk-patch-deps-20260811
Open

cs-raj wants to merge 3 commits into
mainfrom
fix/snyk-patch-deps-20260811

Conversation

@cs-raj

@cs-raj cs-raj commented Aug 11, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Snyk flags qs 6.16.0 on main (high, Uncaught Exception, SNYK-JS-QS-20943482). It comes in through @contentstack/delivery-sdk → @contentstack/core, which pins qs to exactly 6.16.0. npm audit reports 12 findings in the Angular build tooling, and this PR had fallen behind main.

Fix

This is a demo app, so the lock file is what ships. All changes are in package.json and the lock file.

  • Merged main and regenerated package-lock.json.
  • Bumped @angular-devkit/build-angular 21.2.20 → 21.2.28, @angular/cli 21.2.26 → 21.2.28 and vite ^6.4.3 → ^6.4.5 (all patch releases).
  • Added the qs 6.16.1 override. Kept this PR's earlier @hono/node-server 2.0.10 and less 4.7.0 overrides and version 0.1.4.
  • Updated .talismanrc so Talisman also skips base64content in package-lock.json (the lock's integrity hashes).
  • Generated the lock with npm 11, because npm 10.9.9 crashes when it resolves this dependency tree from scratch. npm ci on npm 10 installs it.

What remains: 5 npm audit findings, all in build tooling and all caused by piscina 5.2.0 and undici 7.29.0. The existing overrides on main pin them to those versions. The fixes (5.3.2 and 7.30.1) are on the same major, but this PR does not change them. The 2 MPL-2.0 licence findings (lightningcss) need a policy decision, not a version bump.

Verified: npm run build passes. Snyk 1 → 0, npm audit 12 → 5.

🤖 Generated with Claude Code

Overrides added:
  @hono/node-server: 2.0.6 → 2.0.10 (fixes moderate DoS via aborted WebSocket handshake)
  less: 4.4.2 → 4.7.0 (fixes high infinite-loop vulnerability)

Package version: 0.1.3 → 0.1.4
Vuln count: 6 (before) → 0 (after). Build verified passing.

Skipped (no safe fix available):
  image-size: vulnerable range is *, no safe version to pin
  @modelcontextprotocol/sdk: proposed fix is a cross-major downgrade (1.x → 0.x)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@cs-raj
cs-raj requested a review from a team August 11, 2026 07:12
@snyk-io

snyk-io Bot commented Aug 11, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 0 0 25 ✅ Passed
🟡 Medium Severity 0 2 500 ✅ Passed
🔵 Low Severity 0 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

ℹ️ Vulnerabilities Without Available Fixes (Informational Only)

The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:

  • Critical without fixes: 0
  • High without fixes: 0
  • Medium without fixes: 2
  • Low without fixes: 0

✅ BUILD PASSED - All security checks passed

cs-raj and others added 2 commits October 26, 2026 20:26
Lock file regenerated (fixed 0 Snyk and 3 npm audit findings on its own).
Direct upgrades: @angular-devkit/build-angular 21.2.28, @angular/cli 21.2.28, vite ^6.4.5
Overrides: qs 6.16.1
.talismanrc: package-lock.json entry ignores filecontent + base64content.
Vuln count: snyk 1 → 0, npm audit 12 → 5. Build verified passing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cs-raj
cs-raj requested a review from a team as a code owner October 26, 2026 15:53
@snyk-io

snyk-io Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 0 0 25 ✅ Passed
🟡 Medium Severity 0 2 500 ✅ Passed
🔵 Low Severity 0 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

ℹ️ Vulnerabilities Without Available Fixes (Informational Only)

The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:

  • Critical without fixes: 0
  • High without fixes: 0
  • Medium without fixes: 2
  • Low without fixes: 0

✅ BUILD PASSED - All security checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants