Repository navigation
Fix publishing verification when a local manifest shadows latest #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+146
−54
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| #!/usr/bin/env bash | ||
| # Fault injection exercises failure paths without publishing to a real registry. | ||
| set -euo pipefail | ||
| fixture=$(mktemp -d) | ||
| trap 'rm -rf "$fixture"' EXIT | ||
| mkdir "$fixture/bin" | ||
| cat > "$fixture/bin/podman" <<'PYTHON' | ||
| #!/usr/bin/env python3 | ||
| import json | ||
| import os | ||
| from pathlib import Path | ||
| import sys | ||
|
|
||
| args = sys.argv[1:] | ||
| root = Path(os.environ['FETCHIT_FAULT_DIRECTORY']) | ||
| case = os.environ['FETCHIT_FAULT_CASE'] | ||
| with (root / 'calls').open('a') as calls: | ||
| calls.write(json.dumps(args) + '\n') | ||
| if args[:2] == ['image', 'inspect']: | ||
| architecture = 'amd64' if args[-1] == 'fixture-amd' else 'arm64' | ||
| print(('windows' if case == 'non-linux' else 'linux') + '/' + architecture) | ||
| elif args[0] == 'push': | ||
| if '--digestfile' in args: | ||
| path = Path(args[args.index('--digestfile') + 1]) | ||
| path.write_text('sha256:' + ('a' if path.name == 'amd.digest' else 'b') * 64) | ||
| elif args[:2] == ['manifest', 'push']: | ||
| path = Path(args[args.index('--digestfile') + 1]) | ||
| if case == 'missing': | ||
| pass | ||
| elif case == 'empty': | ||
| path.write_text('') | ||
| elif case == 'malformed': | ||
| path.write_text('not-a-digest') | ||
| elif case == 'unsupported': | ||
| path.write_text('sha512:' + 'c' * 128) | ||
| else: | ||
| path.write_text('sha256:' + 'c' * 64) | ||
| elif args[:2] == ['manifest', 'inspect']: | ||
| if args[-1].endswith('@sha256:' + 'c' * 64): | ||
| (root / 'index-inspected').touch() | ||
| print(json.dumps({'manifests': [ | ||
| {'platform': {'os': 'linux', 'architecture': architecture}, 'digest': 'sha256:' + digit * 64} | ||
| for architecture, digit in [('amd64', 'a'), ('arm64', 'b')] | ||
| ]})) | ||
| else: | ||
| print('{}') | ||
| elif args[:2] not in (['manifest', 'create'], ['manifest', 'add'], ['manifest', 'rm']): | ||
| raise SystemExit('Unexpected fake Podman command: ' + repr(args)) | ||
| PYTHON | ||
| chmod +x "$fixture/bin/podman" | ||
| export PATH="$fixture/bin:$PATH" | ||
| for case in missing empty malformed unsupported non-linux success; do | ||
| directory="$fixture/$case" | ||
| mkdir "$directory" | ||
| status=0 | ||
| FETCHIT_FAULT_CASE="$case" FETCHIT_FAULT_DIRECTORY="$directory" \ | ||
| bash scripts/publish-platform-index.sh example.invalid/test:latest fixture-amd fixture-arm \ | ||
| > "$directory/output" 2>&1 || status=$? | ||
| if [[ "$case" == success ]]; then | ||
| test "$status" = 0 | ||
| test -f "$directory/index-inspected" | ||
| else | ||
| test "$status" != 0 | ||
| test ! -e "$directory/index-inspected" | ||
| case "$case" in | ||
| missing|empty) grep -q 'Missing or empty pushed index digest' "$directory/output" ;; | ||
| malformed|unsupported) grep -q 'Invalid pushed index digest' "$directory/output" ;; | ||
| esac | ||
| fi | ||
| python3 - "$directory/calls" "$case" <<'PYTHON' | ||
| import json | ||
| import sys | ||
| calls = [json.loads(line) for line in open(sys.argv[1])] | ||
| inspections = [call for call in calls if call[:2] == ['manifest', 'inspect']] | ||
| if sys.argv[2] == 'non-linux': | ||
| assert not any(call[0] == 'push' or call[:2] == ['manifest', 'push'] for call in calls), calls | ||
| assert not inspections, inspections | ||
| else: | ||
| # Only the two child preflights may run when the index digest is invalid. | ||
| assert len(inspections) == (3 if sys.argv[2] == 'success' else 2), inspections | ||
| PYTHON | ||
| echo "Publishing fault case passed: $case" | ||
| done |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.