Repository navigation
mount_flags: ignore iversion, noiversion, silent and loud - #2384
Merged
Merged
Conversation
kolyshkin
force-pushed
the
ignore-iversion-silent
branch
from
October 19, 2026 05:44
6a8a504 to
6fb0c57
Compare
The test has a full copy of the mount options list from src/libcrun/mount_flags.perf, which has to be updated every time an option is added, and only catches the case when it is not. Check that a few basic options are present instead. Assisted-by: Claude Code (claude-opus-5-5) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
These options are listed in the runtime spec, but crun does not know them and passes them to the filesystem as data, so e.g. a tmpfs mount with "iversion" fails with EINVAL. Accept and ignore them, as they make no sense on the kernels we support: - i_version is unconditionally enabled by btrfs (since v3.5), xfs v5 (v3.11), ext4 (v6.1, also in EL9) and tmpfs (v6.1), so MS_I_VERSION has no effect there, and it can not be set via the new mount API. - MS_SILENT only silences fill_super error messages when the kernel probes for the filesystem type, which crun never does. The new mount API stopped parsing "silent" in v5.8. Fixes: containers#2330 Assisted-by: Claude Code (claude-opus-5-5) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
force-pushed
the
ignore-iversion-silent
branch
from
October 19, 2026 05:46
6fb0c57 to
17ce4a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These options are listed in the runtime spec, but crun passes them to the filesystem as data, so e.g. a tmpfs mount with
iversionfails withEINVAL.Accept and ignore them, as they make no sense on the kernels we support:
MS_I_VERSIONhas no effect there, and it can not be set via the new mount API.MS_SILENTonly silencesfill_supererror messages when the kernel probes for the filesystem type, which crun never does. The new mount API stopped parsingsilentin v5.8.The first commit stops
tests/test_oci_features.pyfrom duplicating the list of mount options, so adding an option does not require updating the test.This is a simpler alternative to #2381, which forces the legacy
mount(2)path for these flags.Fixes: #2330