Skip to content

conmon: do not fire --timeout early #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kolyshkin merged 1 commit into from
Oct 26, 2026
Merged

conmon: do not fire --timeout early #708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/conmon.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,14 @@ int main(int argc, char *argv[])
}

if (opt_timeout > 0) {
g_timeout_add_seconds(opt_timeout, timeout_cb, NULL);
/*
* Do not use g_timeout_add_seconds here: it rounds the expiration
* to a whole second boundary, and may fire up to 250ms early.
*/
if ((guint)opt_timeout <= G_MAXUINT / 1000)
g_timeout_add((guint)opt_timeout * 1000, timeout_cb, NULL);
else /* Too long for g_timeout_add, imprecision does not matter. */
g_timeout_add_seconds(opt_timeout, timeout_cb, NULL);
}

if (data.exit_status_cache) {
Expand Down
Loading