refactor container_list_windows_test.go to use Tigron#4780
Merged
AkihiroSuda merged 1 commit intoJul 25, 2026
Conversation
46 tasks
Contributor
Author
haytok
suggested changes
Mar 15, 2026
haytok
left a comment
haytok
left a comment
Member
There was a problem hiding this comment.
Have you already checked CI failures related to this PR?
sathiraumesh
suggested changes
Apr 10, 2026
must108
force-pushed
the
containers-list-windows-test
branch
from
April 20, 2026 18:10
189b030 to
374029c
Compare
haytok
reviewed
Apr 23, 2026
Member
|
ping @must108 Could you take a look at the review comments from haytok |
Contributor
Author
|
@haytok apologies for the delay |
Member
|
windows (canary) CI seems constantly failing |
Member
|
Also please squash the commits |
Member
|
ping @must108 |
Member
|
Marking the PR as a draft as the CI is failing. Please click |
AkihiroSuda
marked this pull request as draft
July 18, 2026 21:16
AkihiroSuda
marked this pull request as ready for review
July 22, 2026 07:54
Member
|
The PR is passing CI after restarting, but please make sure to squash the commits @must108 |
Tests now use nerdtest.Setup and Tigron. Updates containerd#4613 Signed-off-by: Mustaeen Ahmed <contact@mustaeen.dev>
must108
force-pushed
the
containers-list-windows-test
branch
from
July 25, 2026 07:39
8eeb32b to
c44c9c1
Compare
Contributor
Author
|
@AkihiroSuda should be good for final review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests now use
nerdtest.Setup, and TigronResolvesUpdates (EDIT: @AkihiroSuda) #4613