Skip to content

Keep libgit2 out of the std feature - #229

Merged
LucaCappelletti94 merged 1 commit into
mainfrom
upstream/std-without-git
Nov 3, 2026
Merged

LucaCappelletti94 merged 1 commit into
mainfrom
upstream/std-without-git

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Collaborator

The std feature turned on git, so a dependent declaring default-features = false, features = ["std"] still built git2, libgit2-sys and tempfile without ever calling Pg2Sqlite::from_git. connetto does exactly that, which puts libgit2 into every client app, and its Tauri iOS build then fails at the Xcode link because libgit2's -lz and -liconv directives never reach it.

git now implies std instead, and the default features carry both, so default users keep from_git. The tests had been reaching tempfile through the optional dependency, so it is also a dev-dependency now, and the MSRV job checks the std-only build and that its dependency graph holds no git2.

@LucaCappelletti94 LucaCappelletti94 added the bug Something isn't working label Nov 3, 2026
@codecov

codecov Bot commented Nov 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@LucaCappelletti94
LucaCappelletti94 merged commit e03be5d into main Nov 3, 2026
20 checks passed
@LucaCappelletti94
LucaCappelletti94 deleted the upstream/std-without-git branch November 3, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant