Repository navigation
Link the integration tests into one test binary - #220
Open
LucaCappelletti94 wants to merge 1 commit into
Open
LucaCappelletti94 wants to merge 1 commit into
LucaCappelletti94 wants to merge 1 commit into
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
These duplicates are not on lines GitHub shows in this pull request diff, the inline comment cannot attach there. The links point at the copies on the head commit.
- group context
tests/helpers/run_translated.rs:36-44it::helpers::run_translated::run_translated_with - group context
tests/it/test_interval_reads.rs:794-802it::test_interval_reads::run_with_failures
LucaCappelletti94
force-pushed
the
upstream/single-test-binary
branch
from
November 2, 2026 12:11
1a5c777 to
e8c5fe5
Compare
There was a problem hiding this comment.
These duplicates are not on lines GitHub shows in this pull request diff, the inline comment cannot attach there. The links point at the copies on the head commit.
- group context
tests/helpers/run_translated.rs:36-44it::helpers::run_translated::run_translated_with - group context
tests/it/test_interval_reads.rs:794-802it::test_interval_reads::run_with_failures
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Every file under tests/ compiled into its own test binary, linking the crate once per file. The files are now modules of a single `it` binary declared from tests/it/main.rs, with autotests off. The tests that register sqlite-vec or SQLiteGIS through sqlite3_auto_extension, which loads the extension into every later connection of the process, keep their own binaries grouped by the extensions they load, and the harness lifecycle test keeps its own because the harness's startup sweep would race its sweep test. The helpers are one shared module, and insta snapshots follow the new module paths.
LucaCappelletti94
force-pushed
the
upstream/single-test-binary
branch
from
November 3, 2026 00:08
e8c5fe5 to
4327c84
Compare
There was a problem hiding this comment.
These duplicates are not on lines GitHub shows in this pull request diff, the inline comment cannot attach there. The links point at the copies on the head commit.
- group context
tests/helpers/run_translated.rs:36-44it::helpers::run_translated::run_translated_with - group context
tests/it/test_interval_reads.rs:794-802it::test_interval_reads::run_with_failures
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every file under
tests/built its own test binary, so the crate was linked 326 times and a release build of the suite took 41G oftarget/release. The files are now modules of oneitbinary declared fromtests/it/main.rs, withautotests = false, and the same build takes 4.3G. Individual tests run ascargo test --test it test_translator::.Four targets stay apart because they need a process of their own.
sqlite_vecandsqlitegishold the tests that register those extensions throughsqlite3_auto_extension, which loads them into every later connection of the process, so sharingitwould hand their functions to tests that prove output against plain SQLite.test_playground_sample_queriesregisters both.test_postgres_harness_lifecyclekeeps its own because the harness sweeps abandoned containers when it starts, which in a shared process races its sweep test.The helpers are one module in
tests/helpers.test_groupswas compiled into two binaries and the declared-list check instatistical_aggregatesinto four, so those now run once. Helpers that nothing called are gone, and insta snapshots moved to the new module paths.