[Common BOM] Remove redundant jetty.version dependencyManagement overrides - #730
Open
Na Lou (nlou9) wants to merge 1 commit into
Open
[Common BOM] Remove redundant jetty.version dependencyManagement overrides#730Na Lou (nlou9) wants to merge 1 commit into
Na Lou (nlou9) wants to merge 1 commit into
Conversation
11 of these entries (jetty-jmx, jetty-server, jetty-http2-server, jetty-alpn-server, jetty-alpn-java-server, jetty-alpn-conscrypt-server, jetty-ee10-servlet, jetty-ee10-servlets, jetty-security, jetty-http2-client, jetty-http2-client-transport) are already managed at the same version (12.0.37) by confluent-common-bom's jetty-bom and jetty-ee10-bom imports, transitively via the common parent POM. jetty-ee10-websocket-jakarta-server is likewise BOM-managed and removed. javax-websocket-server-impl is removed outright: it's a legacy javax-era artifact that doesn't exist in Maven Central at 12.0.37 (Jetty 12 uses jakarta.websocket, not javax) and isn't declared as an actual dependency anywhere in this repo — a dead dependencyManagement entry. Verified via `mvn validate` (full reactor) and `mvn help:effective-pom` on the core and fips-tests modules: all previously-overridden artifacts still resolve to 12.0.37, unchanged.
Na Lou (nlou9)
marked this pull request as ready for review
September 8, 2026 22:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dependencyManagemententries pinning${jetty.version}explicitly, now thatconfluent-common-bom'sjetty-bomandjetty-ee10-bomimports (transitively via thecommonparent POM) already manage them at the same version (12.0.37):jetty-jmx,jetty-server,jetty-http2-server,jetty-alpn-server,jetty-alpn-java-server,jetty-alpn-conscrypt-server,jetty-ee10-servlet,jetty-ee10-servlets,jetty-security,jetty-ee10-websocket-jakarta-server,jetty-http2-client,jetty-http2-client-transport.org.eclipse.jetty.websocket:javax-websocket-server-imploutright — this is a legacy javax-era artifact that doesn't exist in Maven Central at12.0.37(Jetty 12 usesjakarta.websocket, notjavax.websocket) and isn't declared as an actual dependency anywhere in this repo. DeaddependencyManagemententry.rest-utilsisrest-utils-parent— the canonical dependencyManagement source other repos (schema-registry,kafka-rest, etc.) inherit these GAVs from — so unlike a typical downstream consumer, this repo needed the BOM to actually cover these artifacts first. Verified that's now the case as ofconfluent-common-bomv0.1.10 (already live oncommon's published8.0.x).8.0.xonly for now; once merged this should cascade forward viaci-sem-pint/pint merge to8.1.x–8.4.x/masternormally.Test plan
mvn validatepasses across the full reactor (all 5 modules)mvn help:effective-pomoncoreandfips-testsconfirms every previously-overridden artifact still resolves to12.0.37, unchanged🤖 Generated with Claude Code