fix: restore dynamic_fork_tasks_param in DynamicForkTask (re-fixes #349)#444
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…param in DynamicForkTask Fixes the regression introduced in baadd20 that undid PR #352. Setting dynamic_fork_join_tasks_param alongside dynamic_fork_tasks_input_param_name violates Conductor's validation (only one approach is valid at a time). Adds unit tests to prevent this from silently regressing again. Fixes #377
nthmost-orkes
force-pushed
the
fix/dynamic-fork-tasks-param
branch
from
July 23, 2026 03:29
ee9377a to
79141a7
Compare
Contributor
mp-orkes
approved these changes
Jul 23, 2026
mp-orkes
left a comment
Contributor
There was a problem hiding this comment.
LGTM - but please fix the description. We need to understand how this bug came back.
Contributor
Author
CI failure seems unrelated -- can look into it later today, posting in Slack channel for more visibility in case someone else can get to it first. (@chrishagglund-ship-it ?) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-applies the one-line fix from PR #352, which was dropped from main when the branch was subsequently force-pushed/rebased (likely during the Agentspan consolidation). GitHub still shows #352 as "Merged" because it records the merge event, but commit a561d90 is not an ancestor of current main.
Actual timeline:
DynamicForkTask(replacedpre_fork_taskwithtasks_param/tasks_input_param_name) but set the wrong field:dynamic_fork_join_tasks_paraminstead ofdynamic_fork_tasks_param. This is the bug.Setting
dynamic_fork_join_tasks_paramalongsidedynamic_fork_tasks_input_param_nameviolates Conductor's validation: only one approach is valid at a time (dynamicForkJoinTasksParamalone, ordynamicForkTasksParam+dynamicForkTasksInputParamNametogether).User impact: Users calling
DynamicForkTaskwith separatetasks_param/tasks_input_param_namewould get a 400 validation error from the server on workflow registration. Now registers correctly.Test plan
tests/unit/workflow/test_dynamic_fork_task.py— two new unit tests cover the correct param and the join-task variantgenerate_dynamic_fork_taskintests/integration/metadata/test_workflow_definition.pyalready exercises this path against a live serverFixes #377