docs: repair two dead documentation links - #52
Open
leoafarias wants to merge 1 commit into
Open
Conversation
Audited every external URL in the site source. Two returned 404: - mix_lint's "analysis server plugin" link pointed at dart.dev/tools/ analysis-server, which no longer exists. Now dart.dev/tools/analysis. - The Ack API reference pointed at pub.dev/documentation/ack/ack/latest/ack/, which has one path segment too many. Now pub.dev/documentation/ack/latest/. Everything else that redirects still resolves and was left alone, including the DartPad embed URLs, whose dart/flutter variants collapse to a single target when followed.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I audited every external URL in the site source (87 unique links across
src,components,site-tests, andpackages, excluding lockfiles and string templates) by requesting each one. Two returned 404.src/content/documentation/mix/ecosystem/mix-lint.mdxdart.dev/tools/analysis-serverdart.dev/tools/analysissrc/content/documentation/ack/reference/api-reference.mdxpub.dev/documentation/ack/ack/latest/ack/pub.dev/documentation/ack/latest/The Ack one had one path segment too many.
Found but deliberately not changed
dartpad.dev/embed-flutter.html/embed-dart.htmlinDartPadEmbed.tsx. Both redirect, but they collapse to the same target (dartpad.dev/?embed=true), so following the redirect by hand would erase the Dart/Flutter distinction the component depends on. Left as-is.conceptatech.com→concepta.devinWordmark.tsxandapi/waitlist/route.ts. A working redirect, but it looks like a company rebrand rather than a broken link, so it is a branding call. Noteroute.tsalso uses@conceptatech.comas the fallbackRESEND_FROM_EMAILsender — that is a mail domain and should not be changed alongside the web link.twitter.com/leoafarias→x.com/leoafariasinFloatingNavbar.tsxandProductFooter.tsx. Cosmetic; the redirect works.dart.devand MDN links insidepackages/mix_docs_preview— all in generated or boilerplate comments (analysis_options.yaml,pubspec.lockheader, the Flutterweb/index.htmltemplate), not user-facing.linkedin.com(999) andnpmjs.com/package/@bitwild/rockets(403) — bot blocking, not broken.github.com/btwld/*link resolves through one permanent redirect togithub.com/conceptadev/*— this affectsmix,remix,ack,naked_ui, androckets, roughly 80 links, whilebtwld/mix-docsis itself canonicallybtwld. Which direction is correct is a branding decision, so I left them. Same question is noted in btwld/mix#1012.Validation
pnpm run test:site— 40/40 passed.npx tsc --noEmit— clean.pnpm run build— passed; 101 static pages generated.