Repository navigation
Self-contain 2023-bids-dicom figures; annex 12 pointer files in pics/ - #31
Open
yarikoptic wants to merge 2 commits into
Open
yarikoptic wants to merge 2 commits into
yarikoptic wants to merge 2 commits into
Conversation
They were committed through git's clean filter (plain `git add`), so the tree had small "/annex/objects/KEY" pointer files (unlocked) instead of the symlinks (locked) used everywhere else in this dataset. tools/build_preview.py fetches content only for broken symlinks and copies regular files verbatim, so the PR preview served the pointer text instead of the image, e.g. pics/BIDS-minder.svg rendered blank. `git annex lock` turns them into symlinks; keys are unchanged, and the content of all 12 is on datasets.datalad.org. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LioXKDkasSKTUKxXyXn5N1
- BIDS-minder slide loaded bids-standard.github.io/bids-starter-kit/ _images/BIDS-minder.svg, which 404s since the starter kit moved to the BIDS website (bids-standard/bids-starter-kit#414). Use our pics/BIDS-minder.svg instead (same mind map, plus a "Zarr" leaf), sized to fit the slide. - "DICOMs in BIDS" slide loaded dbic-flow.png and dbic-conversions.png from ReproNim/reproin master. Annex copies as pics/dbic-flow.png and pics/dbic-conversions.png, added from URLs pinned to the reproin commit that introduced them (unchanged since). To make their content available (CI's git-annex check, and the datasets.datalad.org mirror): git annex registerurl MD5E-s149431--29e378a46a7294f2f7b040a48136c9bf.png \ https://raw.githubusercontent.com/ReproNim/reproin/fe5488b59c607ead1384da0e3efcbe57770c34e8/docs/source/images/dbic-flow.png git annex registerurl MD5E-s293267--d7a4fa9b78b172ed35d73251763a045f.png \ https://raw.githubusercontent.com/ReproNim/reproin/fe5488b59c607ead1384da0e3efcbe57770c34e8/docs/source/images/dbic-conversions.png git annex get pics/dbic-flow.png pics/dbic-conversions.png git annex copy --to datasets.datalad.org pics/dbic-flow.png pics/dbic-conversions.png git push origin git-annex INDEX.md updated accordingly. Closes #30 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LioXKDkasSKTUKxXyXn5N1
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30.
2023-bids-dicom.html: the BIDS-minder slide's upstream URL 404s (the file was removed from bids-starter-kit in [ENH] Move starter kit to new BIDS website with redirects bids-standard/bids-starter-kit#414); use ourpics/BIDS-minder.svg. The two ReproIn figures on "DICOMs in BIDS" were also hotlinked fromReproNim/reproin@master; they are now annexed aspics/dbic-flow.pngandpics/dbic-conversions.png.pics/BIDS-minder.svgand 11 otherpics/files had been committed as git-annex pointer files (unlocked) instead of symlinks.tools/build_preview.pycopies such files verbatim, so the PR preview served the/annex/objects/...text instead of the image.git annex lockturned them into symlinks. The keys are unchanged and all 12 are on datasets.datalad.org.Before merging, make the two new keys available. The
git-annexbranch was deliberately not pushed from here, so until then thegit-annexcheck fails for exactly these two files. Pushing onlygit-annextriggers no PR event, so re-run that check afterwards. The copy step keeps the datasets.datalad.org mirror from losing the images it hotlinks today:Details
pics/BIDS-minder.svg(158781 B) differs from both upstream versions (171718 B and 203984 B, bids-starter-kit38ce978and212a377). It shows the same mind map plus one extra "Zarr" leaf under "OME Zarr". Its aspect ratio is taller (1718×1234 vs 2023×1303), so at natural size the bottom branch was clipped, hencestyle="height:1000px". I checked this with headless-Chromium screenshots of slide#/6/2; it fits within the deck's 1920×1080 canvas (top 40 px, bottom 1030 px).fe5488b, 2018-03-01). They are byte-identical to currentmaster. They went topics/, next to the existingpics/dbic-conversions-p{1,2}.pngcrops, rather thanpics/borrowed/, because ReproIn is a ReproNim/CON project.0000-zoom-background-qrcode.png,2016-openfmri-dataset-datalad-howto.png,2026-ca-origami-retreat-aicoding-qrcode.png,2026-repronim-YODA-BIDS-webinar-qrcode.png,2026-usrse-con-talk-qrcode.png,202x-mvc-stack-qrcode.png,BIDS-minder.svg,borrowed/arjlover-webshot.png,con-tinuous-term-dandi-cli.png,con_logo_square_with_fuzzybackground.png,datalad-animated.gif,datalad-handbook-basics.svg.annex_check.py check(con/ci-actions@claude/bold-bohr-lvtger) the way CI does, in a clone with only GitHub'sgit-annexbranch. Result: datasets.datalad.org has 12 of 14 keys, and the two ReproIn keys are missing. After theregisterurlcalls above:web: has 2 of 2,All annexed content is available. OK.git-annexbranch change was produced in a clone withannex.private=true, so it touches only thewebremote and URL logs (4 files:*.logand*.log.webfor the two keys). No repository UUID from this session is recorded.dbic-conversions.png(1254×1674) overflows the slide. A follow-up could use the existing-p1/-p2crops as fragments, as2022-nih-compcore.htmldoes.🤖 Generated with Claude Code
https://claude.ai/code/session_01LioXKDkasSKTUKxXyXn5N1
Generated by Claude Code