Skip to content

fix(ci): pass ci / required when release-checks is skipped - #81

Merged
gusfcarvalho merged 1 commit into
mainfrom
ra/sec-fix-ci-required
Oct 8, 2026
Merged

gusfcarvalho merged 1 commit into
mainfrom
ra/sec-fix-ci-required

Conversation

@gusfcarvalho

@gusfcarvalho gusfcarvalho commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Follow-up to #77, which merged with this bug.

Why

#77 added a required job to this repo's ci.yml, named ci / required (the check the ccf-required ruleset requires). It fails on every PR that isn't a release-please PR, as on #78:

required jobs did not succeed:
release-checks: skipped

release-checks calls release-checks.yml, whose only job runs on release-please PRs. A called workflow whose jobs all skip reports skipped, not success, so the copied "anything but success fails" check failed. This blocks every PR here once repo-settings applies ccf-required to workflows.

What

  • ci.yml: release-checks may be skipped. Anything else but success still fails: go or actionlint skipped, failed or cancelled, and release-checks failed or cancelled.
  • TestSelfRequired now runs the check's script on these cases instead of requiring it to match the kind workflows' copy:
    • a release PR passes;
    • another PR (release-checks skipped) passes;
    • a failed release-checks fails;
    • a skipped go fails;
    • a cancelled actionlint fails.

Gate: go test ./internal/ciworkflows and actionlint pass.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Required CI checks now allow the release-check job to be skipped while continuing to flag other unsuccessful jobs.
  • Tests
    • Added coverage for skipped, failed, and cancelled job outcomes.

A called workflow whose jobs all skip reports skipped, not success, so the
required job failed on every PR that isn't a release-please PR (where
release-checks skips). Skipped is accepted for release-checks only; any
other result but success still fails.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 8, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: d516bbb2-1939-42a1-8d21-47a03c597061
📥 Commits

Reviewing files that changed from the base of the PR and between 2a9b345 and 1e26f5f.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • internal/ciworkflows/steps_test.go
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gusfcarvalho
gusfcarvalho merged commit d628ff2 into main Oct 8, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant