Repository navigation
fix(ci): pass ci / required when release-checks is skipped - #81
Merged
Merged
Conversation
A called workflow whose jobs all skip reports skipped, not success, so the required job failed on every PR that isn't a release-please PR (where release-checks skips). Skipped is accepted for release-checks only; any other result but success still fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #77, which merged with this bug.
Why
#77 added a
requiredjob to this repo'sci.yml, namedci / required(the check theccf-requiredruleset requires). It fails on every PR that isn't a release-please PR, as on #78:release-checkscallsrelease-checks.yml, whose only job runs on release-please PRs. A called workflow whose jobs all skip reportsskipped, notsuccess, so the copied "anything but success fails" check failed. This blocks every PR here oncerepo-settingsappliesccf-requiredtoworkflows.What
ci.yml:release-checksmay beskipped. Anything else butsuccessstill fails:gooractionlintskipped, failed or cancelled, andrelease-checksfailed or cancelled.TestSelfRequirednow runs the check's script on these cases instead of requiring it to match the kind workflows' copy:release-checksskipped) passes;release-checksfails;gofails;actionlintfails.Gate:
go test ./internal/ciworkflowsand actionlint pass.🤖 Generated with Claude Code
Summary by CodeRabbit