Repository navigation
Tolerate a missing datacenter.cfg in vm_keyboard_default - #124
Merged
Merged
Conversation
sed exits 2 when the file is absent; with pipefail and inherit_errexit that killed vm_echo_default_settings and vm_mark_created on hosts and CI mocks without one.
Contributor
Try this branchThe engine and the scripts resolve independently, so a production script can COMMUNITY_SCRIPTS_CORE_URL=https://raw.githubusercontent.com/community-scripts/core/fix/keyboard-default-no-datacenter-cfg \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/debian.sh)"Swap This PR touches Run a script from a fork as wellcurl -fsSL https://raw.githubusercontent.com/community-scripts/core/fix/keyboard-default-no-datacenter-cfg/tools/run.sh |
bash -s -- https://raw.githubusercontent.com/YOU/DevScripts/your-branch ct/debian.sh \
https://raw.githubusercontent.com/community-scripts/core/fix/keyboard-default-no-datacenter-cfgNote that Useful flags while testing
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #120
vm_keyboard_defaultpipessedover/etc/pve/datacenter.cfg. Without the file the pipeline exits 2 and, underpipefail+inherit_errexit, abortsvm_echo_default_settingsandvm_mark_created. The DevScripts VM-wizard CI (mocked host, no datacenter.cfg) has been red since. Guard the read; test added.