Repository navigation
Take the ISO storage from the disk pool when it can hold ISOs - #122
Merged
Merged
Conversation
An installer VM asked for a storage twice: once for the disks, once for the ISO. When the pool chosen for the disks also offers ISO content it is used for the ISO as well, so the second question only comes where it must. The disk dialog now says what it is for.
Contributor
Try this branchThe engine and the scripts resolve independently, so a production script can COMMUNITY_SCRIPTS_CORE_URL=https://raw.githubusercontent.com/community-scripts/core/fix/iso-storage-reuse \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/debian.sh)"Swap This PR touches Run a script from a fork as wellcurl -fsSL https://raw.githubusercontent.com/community-scripts/core/fix/iso-storage-reuse/tools/run.sh |
bash -s -- https://raw.githubusercontent.com/YOU/DevScripts/your-branch ct/debian.sh \
https://raw.githubusercontent.com/community-scripts/core/fix/iso-storage-reuseNote that Useful flags while testing
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installer VMs (ZimaOS, BlissOS, CachyOS, Umbrel, TurnKey) ask for a storage twice:
vm_select_storagefor the disks (imagescontent) andvm_select_iso_storagefor the ISO (isocontent), because Proxmox only attaches ISOs from an ISO-capable storage. When the pool chosen for the disks is ISO-capable it now takes the ISO too, so the second dialog appears only when it has to (for example local-lvm disks with several ISO pools).VM_ISO_STORAGEstill wins. The disk dialog says it is for the disks.New case in
tests/vm-iso-storage.sh(22 pass).