Repository navigation
fix(sync-actions): correct Counter literal and pin platform-sdk off latest - #62
Merged
Merged
Conversation
…n type `@commercetools/platform-sdk` declares the skip configuration discriminator as the string literal `'Counter'`, but the recurring orders test used lowercase `'counter'`, failing `tsc` with TS2322. The breakage surfaced after the dependency bump in b2bfcf7 resolved `sync-actions`' `"@commercetools/platform-sdk": "latest"` to 9.4.0. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: ba27b2a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
`"@commercetools/platform-sdk": "latest"` re-resolved to a new version on every lockfile refresh, silently crossing major boundaries and bypassing the `dependencyDashboardApproval` gate Renovate applies to major updates. That is how the 8.x -> 9.x jump landed unreviewed and broke `tsc` on main. A caret range matches the other workspaces (`^8.9.0`) and lets Renovate manage updates through reviewable PRs. Lockfile now resolves to 9.5.0; typecheck and the full sync-actions suite (45 suites, 732 tests) pass against it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ajimae
changed the title
Counter literal for skipConfiguration typeCounter literal and pin platform-sdk off latest
Add a patch changeset so the `latest` -> `^9.4.0` move is recorded in the published CHANGELOG for @commercetools/sync-actions. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two related commits: the first fixes the red
Type checkingjob, the second removes the root cause that let it go red.1.
Counterliteral casingtscwas failing inpackages/sync-actions/test/recurring-orders-sync.spec.ts:@commercetools/platform-sdkdeclares the skip-configuration discriminator capitalised:Both occurrences now use
'Counter'.2.
latest→^9.4.0packages/sync-actions/package.jsoncarried"@commercetools/platform-sdk": "latest". That descriptor re-resolves on every lockfile refresh and happily crosses major boundaries, which bypasses thedependencyDashboardApprovalgaterenovate.jsonapplies to major updates. That is how the 8.x → 9.x jump landed unreviewed and broketsc.A caret range is consistent with the other two workspaces (
^8.9.0) and routes future updates through reviewable Renovate PRs.The lockfile now resolves to 9.5.0 (the newest match), replacing the previous
latest-keyed entry at 9.4.0.Context
mainis currently red for the same reason. Its QA run for b2bfcf7 (33983569258) finished asaction_requiredwith 0 jobs and never executed, so nothing caught it. Merging this fixes main, and #61 picks it up through its merge commit.Verification
Against the resolved 9.5.0:
yarn install --immutable→ exit 0yarn typecheck→ exit 0yarn jest packages/sync-actions→ 45 suites, 732 tests, all passingCI on the first commit was green across all 6 jobs, including both
Regression Testingmatrix legs.🤖 Generated with Claude Code