Repository navigation
Unify notification styles and GitHub run summaries - #19
Merged
Merged
Conversation
This was referenced Nov 15, 2026
Merged
Merged
anilkreddy
marked this pull request as ready for review
November 15, 2026 04:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unify CommerceKit notification cards and run summaries around the existing shared status map and common Result / Inputs / Issues layout. Check, setup, build, deployment and cleanup events show every supplied input name with confidential values redacted, accurate counts and safe failure/warning explanations. Legacy missing input context is explicit. Source statuses, neutral cancellation, action-required semantics and deletion-request initiation meanings remain unchanged.
Notify itself writes a consistent GitHub summary after handled success, warning and failure. It captures all five inputs with webhook masking first, omits event JSON/file contents and paths, and separates delivery success from the source outcome. Summary failures preserve outcomes. Per-field output writes preserve accepted delivery/attempts during output-file errors, report a separate contract issue and never resend or reset known success. Existing delivery, retry and endpoint policy code is unchanged.
Published registry adoption
The owner authorized package publication and green merges. Action-kit #13 merged, and package-only run 43678067818 published actual notification-contract 0.0.6 from main
3fecce40414d709884fa48e48eca278f470b20b0after exact-main CI/CodeQL passed.Notify now pins the exact published registry version with a regenerated real lockfile, reviewed release-age exception and normal standalone bundle. Candidate version escape paths were removed; normal validation needs no flag, source checkout or local file dependency. Registry integrity matches the reviewed candidate exactly:
sha512-n6F84900sDPBeYm5dnf8HLCM9B2DUVATEeF717dqKsSXTJtq1FIj/3hZ2UcNTtXe7v8R90HYF6HIom4auM8Kyw==.8030f643d1dd6d741caa2c3c0ba321ad82b30cca.e4b79576328c2992a96fed087e9ba6e63970e8b54d6fca976a6652702a7a73a9.e9142b35852702017cd44d067c3681ad1bb6e5c2b13ec6f4d666919539d4ac92, identical to the final reviewed candidate.270f2cfe9adcde71cfd59dd3ff94bc7e58c66900.Validation
PASS against the actual registry package, without candidate environment flags: frozen installation/public export checks, bundle, complete
pnpm quality, actionlint and diff checks. 188 tests/13 files, zero skips; 98.12% statements, 93.22% branches, 97.29% functions, 98.95% lines. Existing coverage configuration and source inclusion are unchanged.The suite includes 58 actual standalone bundled-process cases without node_modules or registry credentials, 20 schema fixtures, and 40 intentionally updated provider snapshots. Both providers cover all source outcomes, default/fatal delivery failures, invalid events, file privacy, current-webhook and encoded-secret reflection, Unicode limits, and first-one/first-two output-file faults after HTTP acceptance. All provider fetches are mocked. Public scan (96 files), audit (no known vulnerabilities), byte consistency and workflow lint pass. Independent review reproduced outcome-preservation faults and verified the fixes.
Hosted quality run 43678652611 passed on the normal head. CodeQL run 43678652600 and processed security check
132704432650also passed on that exact head. This PR merged after all hosted checks passed. No protection/check was bypassed.Full registry evidence records provenance and historical candidate validation. The dependency compatibility blocker is resolved. Live provider smoke, Action release/Marketplace review and production SAP validation remain separately authorized gates. Manual smoke only adds fixed synthetic choices and was not dispatched.
Only the shared package was published. No Action release, Git tag, deployment, live provider send, real SAP operation or deletion enablement occurred.
Companions: action-kit #13, Build #8, Deploy #10, cleanup #8, Setup #14, integration harness #3. The coordinated implementation PRs are now merged.
Final coordinated registry validation
All seven original PRs are merged. The dependency-publication/adoption blocker is resolved. Each Action uses actual registry notification-contract 0.0.6 with a frozen reproducible lockfile and regenerated committed bundle. No candidate flag or local package link is required.
Final verified main
abc752ead104a6e5153c5f166d04ee5e595e0ca6: CI/validate 43679092935 and CodeQL 43679092926 PASS. Exact-main processed analysis2169885501has zero results, empty error/warning fields and zero open main alerts.Final registry-installed validation report and sanitized exact-source/bundle evidence: 76 harness tests and the final 24-record five-action integration replay PASS. Four isolated local Sandbox runs were removed with absence verified; Cleanup performed zero target mutations. All 16 provider requests were strict mocks.
The final processed security review found five generated-code alerts in new Build/Deploy test preloads despite green workflow jobs. Narrow test-only follow-ups Build #10 and Deploy #11 removed data-to-code interpolation, passed full validation, and resolved all findings. Production source and bundle hashes are unchanged. Setup used its existing OrganizationAdmin merge exception after all six native jobs, quality and CodeQL passed; no branch rules were changed.
Only the requested shared package was published. No Git tags, Action releases, deployments, hosted Sandbox dispatches, live notifications or real SAP operations occurred. Production cleanup eligibility and separately authorized live/release validation gates remain closed.
Companions: action-kit #13, notify #19, ccv2-build #8, ccv2-deploy #10, setup-commercekit #14, ccv2-build-cleanup #8, action-integration-tests #3.