Repository navigation
feat: render cleanup inputs and success warning failure details - #18
Merged
Merged
Conversation
anilkreddy
marked this pull request as ready for review
November 15, 2026 02:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render cleanup success, failure and warning messages in Slack and Teams with all 14 input names, authentication values always redacted, all aggregate counts, safe failure explanations and warning issues. Successful apply reports accepted deletion requests rather than physical removal; dry-run reports zero actual requests.
Cleanup-only presentation sections preserve complete input context within provider bounds. Public API origins remain visible, oversized previews show explicit truncation, repository context remains, and older cleanup events identify unreported fields. Existing webhook delivery is reused and all 32 non-cleanup golden payloads remain unchanged.
Published dependency and bundle
Notify now pins the actual GitHub Packages
@commercekit-tools/notification-contract@0.0.5, with a regenerated registry lockfile and standalone bundle. The temporary candidate override has been removed; no permanent local links or fake registry versions are used.7cc2e8e6af46e7438064cc6205b22f4f7154eb94.0.0.5, shasumdba01de9635ba79f14ac2bb477c8c828dd4d223f, integritysha512-SMcyyWaeHdtlztt99xtWlJycSAspSTGvCaWJH7M2+u+on77JHwo8boTBOc9UUC0BQHDPo/VHmOj4gpt/XIbqmw==.3f9e418556b190bb8d55ac11a22f554e2c51a4a5; historical candidate evidence is archived in the validation report.20abc47b1408d100b1986830b2ec8b55f02357fc.6c49cb5e49fcdd62d4c6993f4d31d67fb729825e98ee760dac9f8d2e09ffca2f, byte-identical to the reviewed candidate bundle.Validation
PASS using Node 24.21.0 and pnpm 12.6.0 against the published registry package:
pnpm install --no-frozen-lockfile, thenpnpm install --frozen-lockfile.pnpm bundleand completepnpm quality: formatting, lint, strict types, all 19 schema fixtures, 107 tests in 12 files with zero skips, bundle byte consistency, public scan and production dependency audit.git diff --check: PASS; all 32 non-cleanup golden snapshots unchanged.Full evidence and remaining gates.
Hosted quality run 43668192744, CodeQL run 43668192753, and the processed PR CodeQL check all passed on exact head
20abc47b1408d100b1986830b2ec8b55f02357fc. The owner-authorized green merge produced main6331ff4a60956a3a2b546e84d737c9338ca46bda. Post-merge CI 43668309374 and CodeQL 43668309332 also passed; processed main analysis 2169549990 has empty error/warning fields and no open main CodeQL alerts. The dependency-publication blocker is resolved; Notify remains unreleased. Live provider smoke was not run for this change, and production SAP eligibility/cleanup approvals remain separate producer gates. No live webhook delivery, real SAP operation, production cleanup enablement, Action release, release tag or deployment was performed.Companion review set: action-kit #12, cleanup #7, Notify #18. This PR was merged only after all checks passed; no protection or checks were bypassed.