Skip to content

fix: use compatible GitHub release pagination flags #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anilkreddy merged 1 commit into from
Nov 9, 2026
Merged

fix: use compatible GitHub release pagination flags #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions compatibility/tests/workflows.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,3 +101,9 @@ it('marks zero-major package GitHub Releases as prereleases', () => {
const script = readFileSync('scripts/create-package-release.mjs', 'utf8');
expect(script).toContain("version.startsWith('0.') || version.includes('-')");
});

it('release pagination uses gh-compatible JSON processing without mixing slurp and jq', () => {
const script = readFileSync('scripts/create-package-release.mjs', 'utf8');
expect(script).toContain("'--slurp'");
expect(script).not.toContain("'--jq'");
});
16 changes: 4 additions & 12 deletions scripts/create-package-release.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,18 +31,10 @@ const tag = `${name}-v${version}`;
const tags = run('git', ['ls-remote', '--tags', 'origin', `refs/tags/${tag}`]);
if (tags.trim()) throw Error('Package tag already exists; inspect partial release state.');
const releases = JSON.parse(
run('gh', [
'api',
'--paginate',
'--slurp',
`repos/${process.env.GITHUB_REPOSITORY}/releases?per_page=100`,
'--jq',
'[.[][] | .tag_name]',
])
.trim()
.split('\n')
.join(''),
);
run('gh', ['api', '--paginate', '--slurp', `repos/${process.env.GITHUB_REPOSITORY}/releases?per_page=100`]),
)
.flat()
.map((release) => release.tag_name);
if (releases.includes(tag)) throw Error('GitHub Release already exists.');
run(process.execPath, ['scripts/release-checks.mjs', sha]);
const temp = mkdtempSync(join(tmpdir(), 'commercekit-release-'));
Expand Down
Loading