CI: derive the workspace path instead of hardcoding the repo name - #38
Merged
Conversation
The regression-test steps make the workspace traversable for the postgres user by chmod'ing each ancestor directory, and named the middle one literally: /home/runner/work/PL-php. Renaming the repository to plPHP moved the checkout to /home/runner/work/plPHP/plPHP, so that chmod now fails with "cannot access", and since the step runs under "bash -e" every matrix job and the ASAN job fail before a single test runs. Use $(dirname "$GITHUB_WORKSPACE") instead, which is the same directory whatever the repository is called. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The break
Every CI job on the current master fails before running a test:
The "Run the regression tests" and ASAN steps make the workspace traversable for the
postgresuser by chmod'ing each ancestor directory, and named the middle one literally as/home/runner/work/PL-php. Renaming the repository to plPHP moved the checkout to/home/runner/work/plPHP/plPHP, so that path no longer exists. The step runs underbash -e, so the failedchmodtakes the whole job down: all 11 matrix jobs plus ASAN.The fix
Use
$(dirname "$GITHUB_WORKSPACE"), which resolves to the same directory whatever the repository is called. No other behavior changes, and this is the only place the old name was hardcoded outside documentation.This blocks every open PR, so it wants to land first.
🤖 Generated with Claude Code