Repository navigation
Report already closed human tasks as closed, not as the human's own - #249
Merged
Merged
Conversation
…e it Cancelling a task whose agent was deleted said it was the human's own task, because the author check ran before the status check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an agent is deleted, its open human tasks are withdrawn automatically. Cancelling one of them afterwards answered "H-177 is Daniel's own task", because
withdrawHumanTaskchecked the author (now NULL) before the status. The status check now runs first, so the tool answers "H-177 is withdrawn already".packages/core/src/services/humanTasks.ts: status check before the team lead checkpackages/core/test/human-tasks.test.ts: deleting an agent, then cancelling its task, reads as withdrawn (fails without the fix)bun test test/human-tasks.test.ts: 29 pass