Repository navigation
Fix CI: duplicate imports, same-slug tests and unclassified autolink routes - #246
Closed
danielehrhardt wants to merge 2 commits into
Closed
danielehrhardt wants to merge 2 commits into
danielehrhardt wants to merge 2 commits into
Conversation
Reading the suggestions is allowed like GET /api/totp; linking them needs secret access like linking a 2FA code from a missing login.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main has been red since #241, #243 and #245 were merged one after the other (run 40173455998).
remote-snapshot.test.tsimportedclearGroup/setGroupandensureReplica/resetReplicaCachetwice (TS2300)earshot-2/studio-2and the primary's lands too. Both tests now assert that, matching Resolve project slug clashes between device group computers #243's own test for the same case. Keep a secondary's setup copy going when both computers made a row with the same name #241's skip path stays for other unique names (mods).GET/POST /api/totp/autolinkweren't in the cloud scope table: reading suggestions is allowed (likeGET /api/totp), linking needs secret access (likelink-totp).Checked locally: core/shared/desktop typecheck clean,
remote-snapshot+cloud-scopetests 50/50 pass.