Repository navigation
Clear the log once its fix is merged - #244
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When a "Fix in code" ticket (Settings → Logs, a runner's card, or the nightly self-repair check) gets its pull request merged, Godmode now empties the log the ticket came from. Before, those entries stayed in the log, so the next "Fix in code" picked up the same problems again and they were fixed twice.
How
self_repair_tickets: which log (this computer or a runner) each fix ticket was filed from, and when it was cleared.clearFixedLogs()indiagnostics/selfRepair.tsclears the logs of tickets whose PR is merged:clearLogs()locally,DELETE /api/logsover the link for a runner (clearRunnerLog).pr_mergedtask event (auto-merge, approve, and the PR watcher all record it), once at start (catches merges while Godmode was off), and before a log is read for a new ticket (catches a runner that was offline when its fix was merged).Tests
test/self-repair.test.ts: the log stays while the PR is open, is emptied once it's merged, and isn't cleared a second time.self-repair,tasks,subtasks,human-tasks: 117 pass.