Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Sentry events now carry their breadcrumbs into Hawk's native
payload.breadcrumbsfield, so they are rendered by the Breadcrumbs block in Garage like the ones from@hawk.so/javascript.Breadcrumbs were removed from the Sentry worker in #406 because they landed in
addonsas raw JSON, with the note that Hawk should support them first. Hawk now does:EventData.breadcrumbsexists in@hawk.so/types, Garage renders it, and the grouper already sanitizesmessageanddataof every breadcrumb. This PR does not bring back the raw addon: breadcrumbs are still excluded fromaddons.sentry.How
composeBreadcrumbs()inworkers/sentry/src/utils/converter.ts:{ values: [...] }(Python, PHP);Breadcrumb.timestampis required;http/query→request,ui/user→ui,transaction→logic,debug/info→default;navigation,erroranddefaultstay as they are, unknown types pass through unchanged (Garage shows them asdefault);category,message,leveland objectdataas they are.The number of breadcrumbs is left to the SDK (
max_breadcrumbs, 100 by default in Sentry SDKs); the worker does not truncate them.Tests
converter.test.ts: array and{ values }shapes, seconds and RFC 3339 timestamps, fallback to the event timestamp, skipping without a timestamp, type mapping, unknown types, missing breadcrumbs.index.test.ts: an envelope with a PHP/Python-style{ values }payload ends up inpayload.breadcrumbsand not inaddons.sentry.yarn test:sentry: 50 passed.