Conversation
Sawtone
requested review from
TatianaFomina,
gohabereg,
ilyamore88 and
neSpecc
as code owners
September 18, 2026 08:40
Sawtone
force-pushed
the
fix/inline-toolbar-2822
branch
from
September 18, 2026 09:11
5ec0d41 to
3a0c212
Compare
Contributor
Author
|
Updated the regression test for Firefox 115, where formatting an entire text node may not emit selectionchange. The test now explicitly triggers that event after applying/removing bold. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #2822.
This fix keeps the open inline-toolbar container mounted during selection refreshes, preventing flicker and repeated entrance animations. Tools and buttons are still recreated, preserving existing cleanup, including link handling. It also handles positioning, pending interactions, stale renders, and cleanup after render failures.
Validation
13/13 new and 54/54 existing related Cypress cases passed, plus 13/13 checks each in Chromium, Firefox, and WebKit. ESLint reports no errors; TypeScript has the same 719 baseline diagnostics. Tests loaded source through Vite; no distribution build or full local CI run was performed.
Flipper
The unchanged keyboard-navigation test failed in earlier runs on both unmodified v2.31.7 and the earlier prototype. Its 100ms wait can race the 180ms selection debounce, leaving currentBlock undefined; two retries did not consistently resolve it. Flipper remains untouched and was excluded from the final selected run.
More
Retaining tool/button instances could be a separate follow-up.